From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: David Aguilar <davvid@gmail•com>,
Nguyen Thai Ngoc Duy <pclouds@gmail•com>,
git@vger•kernel.org, Michael Haggerty <mhagger@alum•mit.edu>,
Jay Soffian <jaysoffian@gmail•com>,
Jakub Narebski <jnareb@gmail•com>
Subject: Re: config-file includes
Date: Mon, 26 Sep 2011 14:12:08 -0700 [thread overview]
Message-ID: <7vmxdr100n.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110926200553.GA492@sigill.intra.peff.net> (Jeff King's message of "Mon, 26 Sep 2011 16:05:53 -0400")
Jeff King <peff@peff•net> writes:
> We could allow arbitrary shell code like:
>
> [include-if "test `uname -s` -eq Darwin"]
>
> Very flexible, though it makes me think we are getting a little
> overboard. And it's an extra shell invocation whenever we read the
> config, which is ugly.
Let's not go there. It is not even like we only ever call git_config()
once in the lifetime of a process.
next prev parent reply other threads:[~2011-09-26 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 19:58 config-file includes Jeff King
2011-09-26 10:45 ` Nguyen Thai Ngoc Duy
2011-09-26 12:36 ` Jeff King
2011-09-26 19:21 ` David Aguilar
2011-09-26 20:05 ` Jeff King
2011-09-26 21:12 ` Junio C Hamano [this message]
2011-09-27 2:13 ` Jay Soffian
2011-09-27 2:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmxdr100n.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jaysoffian@gmail$(echo .)com \
--cc=jnareb@gmail$(echo .)com \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox