Subject: Re: [PATCHv2 1/2] revlist.c: introduce --left/right-only for unsymmetric picking

From: Junio C Hamano <[email-masked]>
Date: Mon, 21 Feb 2011 17:17:33 -0800

Junio C Hamano <[email-masked]> writes:

> ...  We
> might want to make sure that l/r only are mutually exclusive at the
> command parser, though.

-- >8 --
Subject: [PATCH] rev-list: --left/right-only are mutually exclusive

Signed-off-by: Junio C Hamano <[email-masked]>
---
 revision.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/revision.c b/revision.c
index 0681c7c..1fcaeb7 100644
--- a/revision.c
+++ b/revision.c
@@ -1284,8 +1284,12 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
 	} else if (!strcmp(arg, "--left-right")) {
 		revs->left_right = 1;
 	} else if (!strcmp(arg, "--left-only")) {
+		if (revs->right_only)
+			die("--left-only is incompatible with --right-only");
 		revs->left_only = 1;
 	} else if (!strcmp(arg, "--right-only")) {
+		if (revs->left_only)
+			die("--right-only is incompatible with --left-only");
 		revs->right_only = 1;
 	} else if (!strcmp(arg, "--count")) {
 		revs->count = 1;
-- 
1.7.4.1.107.ga7184