public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: "Joachim Schmitz" <jojo@schmitz-digital•de>
Cc: <git@vger•kernel.org>, "'Johannes Sixt'" <j6t@kdbg•org>
Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it
Date: Tue, 04 Sep 2012 11:47:17 -0700	[thread overview]
Message-ID: <7vobllaami.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vwr09abim.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Tue, 04 Sep 2012 11:28:01 -0700")

Junio C Hamano <gitster@pobox•com> writes:

> "Joachim Schmitz" <jojo@schmitz-digital•de> writes:
>
>>> Only with the observation of "clone", I cannot tell if your timer is
>>> working.  You can try repacking the test repository you created by
>>> your earlier "git clone" with "git repack -a -d -f" and see what
>>> happens.
>>
>> It does update the counter too.
>
> Yeah, that was not a very good way to diagnose it.
>
> You see the progress from pack-objects (which is the underlying
> machinery "git repack" uses) only because it knows how many objects
> it is going to pack, and it updates the progress meter for every
> per-cent progress it makes, without any help from the timer
> interrupt.

I think the "Counting objects: $number" phase is purely driven by
the timer, as there is no way to say "we are done X per-cent so
far".

Doesn't your repack show "Counting objects: " with a number once,
pause forever and then show "Counting objects: $number, done."?

  reply	other threads:[~2012-09-04 18:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24 10:39 [PATCH 1/2] Support for setitimer() on platforms lacking it Joachim Schmitz
2012-08-28 20:15 ` Junio C Hamano
2012-08-30 16:40   ` Joachim Schmitz
2012-08-30 17:13     ` Junio C Hamano
2012-08-30 17:22       ` Joachim Schmitz
2012-09-01  9:50       ` Joachim Schmitz
2012-09-02 20:43         ` Junio C Hamano
2012-09-03  9:31           ` Joachim Schmitz
2012-09-03 18:15             ` Johannes Sixt
2012-09-03 18:57               ` Junio C Hamano
2012-09-03 19:03             ` Junio C Hamano
2012-09-03 20:05               ` Joachim Schmitz
2012-09-04 16:58                 ` Junio C Hamano
2012-09-04 17:23                   ` Joachim Schmitz
2012-09-04 18:28                     ` Junio C Hamano
2012-09-04 18:47                       ` Junio C Hamano [this message]
2012-09-04 21:47                         ` Joachim Schmitz
2012-09-04 22:44                           ` Junio C Hamano
2012-09-05  9:59                             ` Joachim Schmitz
2012-09-04 18:48                     ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vobllaami.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=j6t@kdbg$(echo .)org \
    --cc=jojo@schmitz-digital$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox