Subject: Re: [PATCH v4 11/13] status: add --column

From: Junio C Hamano <[email-masked]>
Date: Fri, 03 Feb 2012 15:19:54 -0800

Nguyễn Thái Ngọc Duy  <[email-masked]> writes:

> @@ -1251,7 +1260,7 @@ int cmd_status(int argc, const char **argv, const char *prefix)
>  	case STATUS_FORMAT_LONG:
>  		s.verbose = verbose;
>  		s.ignore_submodule_arg = ignore_submodule_arg;
> -		wt_status_print(&s);
> +		wt_status_print(&s, colopts);
>  		break;
>  	}

Do you really need to pass colopts around as a separate parameter all the
way through the callchain?

Why isn't it a new member of wt_status that sits next to existing
use_color, verbose, etc. that define _how_ the status is shown?