From: Junio C Hamano <gitster@pobox•com>
To: Paolo Bonzini <bonzini@gnu•org>
Cc: <git@vger•kernel.org>
Subject: Re: [PATCH RFC 2/8] push: add push.default = mirror
Date: Mon, 20 Jul 2009 13:46:05 -0700 [thread overview]
Message-ID: <7vocrfulpu.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1248112195-3761-3-git-send-email-bonzini@gnu.org> (Paolo Bonzini's message of "Mon\, 20 Jul 2009 19\:49\:49 +0200")
Paolo Bonzini <bonzini@gnu•org> writes:
> This patch adds a new value for push.default. The aim of the series is
> to support all push.default values as arguments to `--push' in git-clone
> and git-remote, and if push.default=mirror works it is easy to make
> `--mirror' a synonym for `--push=mirror' in those comments.
>
> Signed-off-by: Paolo Bonzini <bonzini@gnu•org>
> ---
> Documentation/config.txt | 2 ++
> builtin-push.c | 12 ++++++++++--
> cache.h | 1 +
> config.c | 4 +++-
> 4 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 4c27e9d..fa5eb76 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -1290,6 +1290,8 @@ push.default::
> * `matching` push all matching branches.
> All branches having the same name in both ends are considered to be
> matching. This is the default.
> +* `mirror` pushes all branches forcing non fast-forward updates and
> + deletes branches that do not exist anymore locally.
> * `tracking` push the current branch to its upstream branch.
> * `current` push the current branch to a branch of the same name.
I think this patch alone (regardless of the rest which I haven't read)
probably makes sense.
Except that I think the part below contradicts with the --mirror push
semantics (see remote.c::match_refs()).
> diff --git a/builtin-push.c b/builtin-push.c
> index e678a9d..8a312a3 100644
> --- a/builtin-push.c
> +++ b/builtin-push.c
> @@ -74,6 +73,10 @@ static void setup_default_push_refspecs(void)
> add_refspec(":");
> break;
>
> + case PUSH_DEFAULT_MIRROR:
> + add_refspec("+refs/*:refs/*");
> + break;
> +
next prev parent reply other threads:[~2009-07-20 20:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 17:49 [PATCH RFC 0/8] introduce 'git remote add --push' and 'git clone --push' Paolo Bonzini
2009-07-20 17:49 ` [PATCH RFC 1/8] reintroduce PUSH_DEFAULT_UNSPECIFIED Paolo Bonzini
2009-07-20 17:49 ` [PATCH RFC 2/8] push: add push.default = mirror Paolo Bonzini
2009-07-20 20:46 ` Junio C Hamano [this message]
2009-07-20 21:14 ` Paolo Bonzini
2009-07-20 21:34 ` Junio C Hamano
2009-07-20 21:36 ` Paolo Bonzini
2009-07-20 17:49 ` [PATCH RFC 3/8] git remote add: refactor configuration Paolo Bonzini
2009-07-20 17:49 ` [PATCH RFC 4/8] git remote add: add --push option Paolo Bonzini
2009-07-20 17:49 ` [PATCH RFC 5/8] clone: refactoring of building the fetch refspec Paolo Bonzini
2009-07-20 17:49 ` [PATCH RFC 6/8] clone: use setup_remote_config Paolo Bonzini
2009-07-20 17:49 ` [PATCH RFC 7/8] config: add git_config_norepo Paolo Bonzini
2009-07-20 17:49 ` [PATCH RFC 8/8] clone: add --push option Paolo Bonzini
2009-07-20 22:15 ` [PATCH RFC 0/8] introduce 'git remote add --push' and 'git clone --push' Junio C Hamano
2009-07-21 10:33 ` Paolo Bonzini
2009-07-21 21:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vocrfulpu.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=bonzini@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox