From: Junio C Hamano <gitster@pobox•com>
To: Brandon Casey <casey@nrlssc•navy.mil>
Cc: git@vger•kernel.org, Arjen Laarhoven <arjen@yaph•org>,
Jeff King <peff@peff•net>,
"Shawn O. Pearce" <spearce@spearce•org>,
"Mike Ralphson" <mike@abacus•co.uk>
Subject: Re: What's in git.git (Oct 2008, #03; Tue, 14)
Date: Thu, 23 Oct 2008 19:44:27 -0700 [thread overview]
Message-ID: <7vod1a3e5w.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <bsftmRx17krWBpVlulipoJEO1fWsD0hZfF3HOZcajX6GV66RKW8W6A@cipher.nrlssc.navy.mil> (Brandon Casey's message of "Wed, 15 Oct 2008 10:35:30 -0500")
Brandon Casey <casey@nrlssc•navy.mil> writes:
> 2) Do we want to stick with compat/regex on
>
> Darwin: Arjen
> FreeBSD: Jeff
> AIX: Mike
>
> now that the builtin funcname patterns have been converted to Extended
> Regular Expressions?
-- >8 --
Subject: Stop using compat/regex.c on platforms with working regexp library
We used to have non-POSIX comformant BRE in our code, and linked with GNU
regexp library on a few platforms (Darwin, FreeBSD and AIX) to work it
around. This was backwards.
We've fixed the broken regexps to use ERE that native regexp libraries on
these platforms can handle just fine. There is no need to link with GNU
regexp library on these platforms anymore.
Tested-on-AIX-by: Mike Ralphson <mike@abacus•co.uk>
Tested-on-FreeBSD-by: Jeff King <peff@peff•net>
Tested-on-Darwin-by: Arjen Laarhoven <arjen@yaph•org>
Tested-on-Darwin-by: Pieter de Bie <pieter@frim•nl>
Signed-off-by: Junio C Hamano <gitster@pobox•com>
---
Makefile | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git c/Makefile w/Makefile
index d6f3695..40309e1 100644
--- c/Makefile
+++ w/Makefile
@@ -640,8 +640,6 @@ ifeq ($(uname_S),Darwin)
endif
NO_STRLCPY = YesPlease
NO_MEMMEM = YesPlease
- COMPAT_CFLAGS += -Icompat/regex
- COMPAT_OBJS += compat/regex/regex.o
endif
ifeq ($(uname_S),SunOS)
NEEDS_SOCKET = YesPlease
@@ -692,8 +690,6 @@ ifeq ($(uname_S),FreeBSD)
BASIC_LDFLAGS += -L/usr/local/lib
DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
THREADED_DELTA_SEARCH = YesPlease
- COMPAT_CFLAGS += -Icompat/regex
- COMPAT_OBJS += compat/regex/regex.o
endif
ifeq ($(uname_S),OpenBSD)
NO_STRCASESTR = YesPlease
@@ -720,8 +716,6 @@ ifeq ($(uname_S),AIX)
INTERNAL_QSORT = UnfortunatelyYes
NEEDS_LIBICONV=YesPlease
BASIC_CFLAGS += -D_LARGE_FILES
- COMPAT_CFLAGS += -Icompat/regex
- COMPAT_OBJS += compat/regex/regex.o
endif
ifeq ($(uname_S),GNU)
# GNU/Hurd
next prev parent reply other threads:[~2008-10-24 2:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 22:08 What's in git.git (Oct 2008, #03; Tue, 14) Junio C Hamano
2008-10-15 15:35 ` Brandon Casey
2008-10-15 17:25 ` Mike Ralphson
2008-10-15 19:38 ` Junio C Hamano
2008-10-15 20:20 ` Shawn O. Pearce
2008-10-15 20:26 ` Junio C Hamano
2008-10-15 20:36 ` Shawn O. Pearce
2008-10-16 0:58 ` [PATCH maint 1/2] t4018-diff-funcname: rework negated last expression test drafnel
[not found] ` <1224118730-24711-1-git-send-email-drafnel@gmail.com>
2008-10-16 0:58 ` [PATCH maint 2/2] t4018-diff-funcname: demonstrate end of line funcname matching flaw drafnel
2008-10-16 10:08 ` What's in git.git (Oct 2008, #03; Tue, 14) Jeff King
2008-10-16 15:21 ` Brandon Casey
2008-10-16 15:37 ` Pieter de Bie
2008-10-17 7:02 ` Arjen Laarhoven
2008-10-24 2:44 ` Junio C Hamano [this message]
2008-10-17 9:53 ` Jeff King
2008-10-17 23:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vod1a3e5w.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=arjen@yaph$(echo .)org \
--cc=casey@nrlssc$(echo .)navy.mil \
--cc=git@vger$(echo .)kernel.org \
--cc=mike@abacus$(echo .)co.uk \
--cc=peff@peff$(echo .)net \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox