From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@imag•fr>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Tommi Virtanen <tv@eagain•net>,
Mikael Magnusson <mikachu@gmail•com>,
Johannes Sixt <johannes.sixt@telecom•at>,
Paolo Bonzini <bonzini@gnu•org>,
Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] git wrapper: execute git-shell when argv[1] is '-c'
Date: Tue, 26 Aug 2008 10:43:40 -0700 [thread overview]
Message-ID: <7vod3facz7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <vpqy72ktgg7.fsf@bauges.imag.fr> (Matthieu Moy's message of "Tue, 26 Aug 2008 08:53:44 +0200")
Matthieu Moy <Matthieu.Moy@imag•fr> writes:
> Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
>
>> On Tue, 26 Aug 2008, Tommi Virtanen wrote:
>>
>>> All I'm going to say is that that's not the way you build trustable
>>> software. You take a minimal interface and restrict untrusted users to
>>> that, you don't add a feature to the widest possible interface..
>>
>> I do not get your point.
>
> With your patch, AAUI, one would put /usr/bin/git as a shell in
> passwd....
Well, it was sheer stupidity of mine.
Let's stop this and apply this patch instead. The patch text is obvious
so I won't quote.
-- * --
From: Junio C Hamano <gitster@pobox•com>
Date: Mon, 25 Aug 2008 22:39:17 -0700
Subject: [PATCH] Revert "Build-in "git-shell""
This reverts commit daa0cc9a92c9c2c714aa5f7da6d0ff65b93e0698.
It was a stupid idea to do this; when run as a log-in shell,
it is spawned with argv[0] set to "-git-shell", so the usual
name-based dispatch would not work to begin with.
Signed-off-by: Junio C Hamano <gitster@pobox•com>
Makefile | 2 +-
builtin-shell.c | 90 -------------------------------------------------------
builtin.h | 1 -
git.c | 1 -
shell.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 90 insertions(+), 93 deletions(-)
--
1.6.0.1.113.g0a79b
next prev parent reply other threads:[~2008-08-26 17:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 20:23 [PATCH] "git shell" won't work, need "git-shell" Tommi Virtanen
2008-08-24 20:36 ` Junio C Hamano
2008-08-24 20:38 ` Tommi Virtanen
2008-08-24 21:20 ` Junio C Hamano
2008-08-24 22:25 ` Tommi Virtanen
2008-08-25 10:37 ` Johannes Schindelin
2008-08-25 11:44 ` Paolo Bonzini
2008-08-25 17:58 ` Johannes Schindelin
2008-08-25 18:25 ` Mikael Magnusson
2008-08-25 20:08 ` Johannes Schindelin
2008-08-25 20:28 ` Johannes Schindelin
2008-08-25 20:51 ` [PATCH 1/2] git wrapper: Make while loop more reader-friendly Johannes Schindelin
2008-08-25 20:52 ` [PATCH 2/2] git wrapper: execute git-shell when argv[1] is '-c' Johannes Schindelin
2008-08-25 21:03 ` Tommi Virtanen
2008-08-25 22:05 ` Johannes Schindelin
2008-08-25 22:20 ` Tommi Virtanen
2008-08-26 0:52 ` Johannes Schindelin
2008-08-26 6:53 ` Matthieu Moy
2008-08-26 17:43 ` Junio C Hamano [this message]
2008-08-26 8:50 ` [PATCH 1/2] git wrapper: Make while loop more reader-friendly Mike Ralphson
2008-08-25 17:08 ` [PATCH] "git shell" won't work, need "git-shell" Petr Baudis
2008-08-25 17:20 ` Dmitry Potapov
2008-08-25 17:26 ` Tommi Virtanen
2008-08-25 17:53 ` Dmitry Potapov
2008-08-25 18:17 ` Johannes Schindelin
2008-08-25 20:26 ` Dmitry Potapov
2008-08-25 20:40 ` Mike Hommey
2008-10-28 11:11 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vod3facz7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=Matthieu.Moy@imag$(echo .)fr \
--cc=bonzini@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.sixt@telecom$(echo .)at \
--cc=mikachu@gmail$(echo .)com \
--cc=tv@eagain$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox