From: Junio C Hamano <gitster@pobox•com>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: "Brandon Casey" <drafnel@gmail•com>,
"Brandon Casey" <casey@nrlssc•navy.mil>,
"Git Mailing List" <git@vger•kernel.org>,
"Alex Riesen" <raa.lkml@gmail•com>,
"Kristian Høgsberg" <krh@redhat•com>
Subject: Re: [PATCH 2/2] close_lock_file(): new function in the lockfile API
Date: Wed, 16 Jan 2008 12:36:54 -0800 [thread overview]
Message-ID: <7vodblo6c9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0801161207220.2806@woody.linux-foundation.org> (Linus Torvalds's message of "Wed, 16 Jan 2008 12:08:58 -0800 (PST)")
Linus Torvalds <torvalds@linux-foundation•org> writes:
> On Wed, 16 Jan 2008, Junio C Hamano wrote:
>> +
>> +void close_lock_file(struct lock_file *lk)
>> +{
>> + close(lk->fd);
>> + lk->fd = -1;
>> +}
>
> Since one of the main purposes of closing would be the error testing of
> writes that haven't made it out yet on filesystems like NFS that do
> open-close cache serialization, I'd suggest doing this as
>
> int close_lock_file(struct lock_file *lk)
> {
> int fd = lk->fd;
> lk->df = -1;
> return close(fd);
> }
>
> to give the return code.
Yup! You are as always right.
next prev parent reply other threads:[~2008-01-16 20:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 22:11 git-commit fatal: Out of memory? mmap failed: Bad file descriptor Brandon Casey
2008-01-11 22:18 ` Charles Bailey
2008-01-12 4:56 ` Jeff King
2008-01-11 22:19 ` Marco Costalba
2008-01-11 22:47 ` Brandon Casey
2008-01-11 23:48 ` Junio C Hamano
2008-01-12 0:43 ` Brandon Casey
2008-01-12 1:08 ` Junio C Hamano
2008-01-12 20:16 ` Alex Riesen
2008-01-14 23:22 ` Brandon Casey
2008-01-15 2:42 ` Brandon Casey
2008-01-15 5:42 ` Linus Torvalds
2008-01-15 17:26 ` Brandon Casey
2008-01-15 17:36 ` Linus Torvalds
2008-01-15 18:27 ` Brandon Casey
2008-01-15 18:50 ` Linus Torvalds
2008-01-15 19:43 ` Brandon Casey
2008-01-15 20:00 ` Kristian Høgsberg
2008-01-15 20:27 ` Brandon Casey
2008-01-15 20:39 ` Brandon Casey
2008-01-15 20:09 ` Linus Torvalds
2008-01-15 20:20 ` Linus Torvalds
2008-01-15 23:10 ` Junio C Hamano
2008-01-16 1:27 ` Junio C Hamano
2008-01-16 2:11 ` Brandon Casey
2008-01-16 19:00 ` [PATCH 1/2] Document lockfile API Junio C Hamano
2008-01-16 19:05 ` [PATCH 2/2] close_lock_file(): new function in the " Junio C Hamano
2008-01-16 20:08 ` Linus Torvalds
2008-01-16 20:36 ` Junio C Hamano [this message]
2008-01-16 20:46 ` Brandon Casey
2008-01-16 21:57 ` Junio C Hamano
2008-01-16 22:46 ` Brandon Casey
2008-01-16 22:55 ` Junio C Hamano
2008-01-16 23:08 ` Brandon Casey
2008-01-16 23:16 ` Brandon Casey
2008-01-16 23:19 ` Junio C Hamano
2008-01-16 23:28 ` Brandon Casey
2008-01-16 7:53 ` git-commit fatal: Out of memory? mmap failed: Bad file descriptor Johannes Sixt
2008-01-15 12:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vodblo6c9.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=casey@nrlssc$(echo .)navy.mil \
--cc=drafnel@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=krh@redhat$(echo .)com \
--cc=raa.lkml@gmail$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox