public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Eric Wong <normalperson@yhbt•net>
Cc: "David D. Kilzer" <ddkilzer@kilzer•net>, git@vger•kernel.org
Subject: Re: [PATCH] Remove duplication in t9119-git-svn-info.sh
Date: Wed, 02 Jan 2008 02:27:24 -0800	[thread overview]
Message-ID: <7vodc4y12r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080102034317.GB11711@untitled> (Eric Wong's message of "Tue, 1 Jan 2008 19:43:17 -0800")

Eric Wong <normalperson@yhbt•net> writes:

> Nevertheless, does your change make things work with older
> versions of SVN?  I'm running 1.4.x everywhere these days, but
> I seem to recall the version of SVN on kernel.org was giving
> Junio trouble with the tests.

Ahh, you are right.  Here is what I am getting.

$ sh t9119-git-svn-info.sh -i -v
* expecting success: 
	mkdir info &&
	cd info &&
		echo FIRST > A &&
		echo one > file &&
		ln -s file symlink-file &&
		mkdir directory &&
		touch directory/.placeholder &&
		ln -s directory symlink-directory &&
		svn import -m 'initial' . file:///home/junio/git/t/trash/svnrepo &&
	cd .. &&
	mkdir gitwc &&
	cd gitwc &&
		git-svn init file:///home/junio/git/t/trash/svnrepo &&
		git-svn fetch &&
	cd .. &&
	svn co file:///home/junio/git/t/trash/svnrepo svnwc &&
	ptouch file &&
	ptouch directory &&
	ptouch symlink-file &&
	ptouch symlink-directory
	
Adding         file
Adding         A
Adding         symlink-file
Adding         directory
Adding         directory/.placeholder
Adding         symlink-directory

Committed revision 1.
Initialized empty Git repository in .git/
	A	file
	A	A
	A	symlink-file
	A	directory/.placeholder
	A	symlink-directory
r1 = 153bc4aeb5ed1375deb17b3611c1d2177ff2e5a4 (git-svn)
Checked out HEAD:
  file:///home/junio/git/t/trash/svnrepo r1
A    svnwc/file
A    svnwc/A
A    svnwc/symlink-file
A    svnwc/directory
A    svnwc/directory/.placeholder
A    svnwc/symlink-directory
Checked out revision 1.
*   ok 1: setup repository and import

* expecting success: 
	(cd svnwc; svn info) > expected.info &&
	(cd gitwc; git-svn info) > actual.info &&
	git-diff expected.info actual.info
	
*   ok 2: info

* expecting success: 
	test $(cd gitwc; git-svn info --url) = $svnrepo
	
*   ok 3: info --url

* expecting success: 
	(cd svnwc; svn info .) > expected.info-dot &&
	(cd gitwc; git-svn info .) > actual.info-dot &&
	git-diff expected.info-dot actual.info-dot
	
*   ok 4: info .

* expecting success: 
	test $(cd gitwc; git-svn info --url .) = $svnrepo
	
*   ok 5: info --url .

* expecting success: 
	(cd svnwc; svn info file) > expected.info-file &&
	(cd gitwc; git-svn info file) > actual.info-file &&
	git-diff expected.info-file actual.info-file
	
diff --git a/expected.info-file b/actual.info-file
index 23b45e2..e7f3924 100644
--- a/expected.info-file
+++ b/actual.info-file
@@ -10,6 +10,5 @@ Last Changed Author: junio
 Last Changed Rev: 1
 Last Changed Date: 2008-01-02 10:25:19 +0000 (Wed, 02 Jan 2008)
 Text Last Updated: 2008-01-02 10:25:20 +0000 (Wed, 02 Jan 2008)
-Properties Last Updated: 2008-01-02 10:25:20 +0000 (Wed, 02 Jan 2008)
 Checksum: 5bbf5a52328e7439ae6e719dfe712200
 
* FAIL 6: info file
	
		(cd svnwc; svn info file) > expected.info-file &&
		(cd gitwc; git-svn info file) > actual.info-file &&
		git-diff expected.info-file actual.info-file
		

  parent reply	other threads:[~2008-01-02 10:28 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-22  6:11 What's in git/spearce.git (stable) Shawn O. Pearce
2007-11-01  5:39 ` What's in git.git (stable) Junio C Hamano
2007-11-04  3:52   ` Junio C Hamano
2007-11-08  8:06     ` Junio C Hamano
2007-11-08 11:38       ` Pierre Habouzit
2007-11-12  7:06       ` Junio C Hamano
2007-11-15  0:20         ` Junio C Hamano
2007-11-17 21:00           ` Junio C Hamano
2007-11-25 20:45             ` Junio C Hamano
2007-12-01  2:05               ` Junio C Hamano
2007-12-04  8:43                 ` Junio C Hamano
2007-12-05 10:57                   ` Junio C Hamano
2007-12-07  9:50                     ` Junio C Hamano
2007-12-09 10:32                       ` Junio C Hamano
2007-12-10 22:37                         ` v1.5.4 plans Junio C Hamano
2007-12-10 23:49                           ` Jeff King
2007-12-11  1:27                             ` Junio C Hamano
2007-12-11  5:02                               ` Junio C Hamano
2007-12-11  6:39                                 ` Jeff King
2007-12-11  6:47                                   ` Junio C Hamano
2007-12-11  6:54                                     ` Jeff King
2007-12-11  7:00                                       ` Junio C Hamano
2007-12-11  7:03                                         ` Jeff King
2007-12-11  6:17                               ` Jeff King
2007-12-11  6:27                                 ` Jeff King
2007-12-11  6:28                                 ` [PATCH 2/2] git-svn: get color config from --get-colorbool Jeff King
2007-12-12 18:27                                   ` Eric Wong
2007-12-11  7:01                               ` v1.5.4 plans Jeff King
2007-12-11  7:05                               ` Andreas Ericsson
2007-12-11 12:53                               ` Jeff King
2007-12-11  3:53                           ` Nicolas Pitre
2007-12-11 12:57                             ` Johannes Schindelin
2007-12-11 13:59                               ` Nicolas Pitre
2007-12-11 15:24                           ` Kristian Høgsberg
2007-12-11 19:13                             ` Junio C Hamano
2007-12-12 18:40                           ` Eric Wong
2007-12-12 19:50                             ` Junio C Hamano
2007-12-12 22:21                               ` David D. Kilzer
2007-12-31  3:56                             ` David D. Kilzer
2007-12-31 20:07                               ` [PATCH] Fix race condition in t9119-git-svn-info.sh David D. Kilzer
2007-12-31 22:29                                 ` Junio C Hamano
2007-12-31 23:33                                   ` [PATCH] Remove duplication " David D. Kilzer
2008-01-02  3:43                                     ` Eric Wong
2008-01-02  3:54                                       ` David D. Kilzer
2008-01-02  5:57                                       ` Junio C Hamano
2008-01-02 10:27                                       ` Junio C Hamano [this message]
2007-12-13  2:47                         ` What's in git.git (stable frozen) Junio C Hamano
2007-12-13  3:09                           ` [PATCH] git-commit: squelch needless message during an empty merge Junio C Hamano
2007-12-13  4:34                             ` Jeff King
2007-12-13  7:46                             ` Johannes Sixt
2007-12-17  8:40                           ` What's in git.git (stable frozen) Junio C Hamano
2007-12-23  9:21                             ` Junio C Hamano
2008-01-05 10:46                               ` Junio C Hamano
2008-01-05 21:21                                 ` Dan McGee
2008-01-06  2:56                                   ` Junio C Hamano
2008-01-06  3:06                                     ` Junio C Hamano
2008-01-06  3:08                                       ` Dan McGee
2008-01-06 10:33                                         ` Junio C Hamano
     [not found]                                 ` <e5bfff550801050507x369976b7sd5e112451bc90331@mail.gmail.com>
2008-01-05 22:11                                   ` Junio C Hamano
2008-01-06  4:24                                 ` Jeff King
2008-01-06  4:29                                   ` Jeff King
2008-01-06 10:51                                     ` Junio C Hamano
2008-01-06 11:17                                       ` Jeff King
2008-01-06 12:32                                         ` Junio C Hamano
2008-01-06 20:59                                           ` Jeff King
2008-01-06 21:22                                             ` Junio C Hamano
2008-01-07  1:48                                               ` Jeff King
2008-01-07  8:27                                 ` Junio C Hamano
2008-01-07 21:58                                   ` Paul Mackerras
2008-01-07 22:05                                     ` Christian Stimming
2008-01-07 22:14                                       ` Junio C Hamano
2007-12-17 21:52                           ` Steffen Prohaska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vodc4y12r.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=ddkilzer@kilzer$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=normalperson@yhbt$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox