From: Junio C Hamano <gitster@pobox•com>
To: Jonas Fonseca <fonseca@diku•dk>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Allow git-instaweb to be run from bare repositories
Date: Fri, 02 Nov 2007 12:11:27 -0700 [thread overview]
Message-ID: <7vodec31k0.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20071102090922.GA10141@diku.dk
Jonas Fonseca <fonseca@diku•dk> writes:
> Signed-off-by: Jonas Fonseca <fonseca@diku•dk>
> ---
> git-instaweb.sh | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> On IRC yesterday, two were asking for this and it seems simply enough.
> Apparently, git-instaweb is a great way to see if you've set up a
> remote repository correctly.
>
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 95c3e5a..14917ac 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -6,6 +6,7 @@ USAGE='[--start] [--stop] [--restart]
> [--local] [--httpd=<httpd>] [--port=<port>] [--browser=<browser>]
> [--module-path=<path> (for Apache2 only)]'
>
> +SUBDIRECTORY_OK=Yes
> . git-sh-setup
>
> fqgitdir="$GIT_DIR"
I'd agree with the goal of the patch, and I would not doubt the
patch worked for you, but it somewhat feels wrong that you can
say "It is Ok to run this script from a subdirectory" and that
is the magic to allow something to work in a bare repository.
Care to share your insights on what is going on?
next prev parent reply other threads:[~2007-11-02 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 9:09 [PATCH] Allow git-instaweb to be run from bare repositories Jonas Fonseca
2007-11-02 19:11 ` Junio C Hamano [this message]
2007-11-08 15:46 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vodec31k0.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=fonseca@diku$(echo .)dk \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox