From: Junio C Hamano <junkio@cox•net>
To: "Torgil Svensson" <torgil.svensson@gmail•com>
Cc: "Martin Waitz" <tali@admingilde•org>,
"Junio C Hamano" <junkio@cox•net>,
git@vger•kernel.org
Subject: Re: [PATCH] rename dirlink to gitlink.
Date: Mon, 21 May 2007 16:32:51 -0700 [thread overview]
Message-ID: <7vodkdbvmk.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <e7bda7770705211612w3ce1b7dew8d48f1ddeb7d100e@mail.gmail.com> (Torgil Svensson's message of "Tue, 22 May 2007 01:12:02 +0200")
"Torgil Svensson" <torgil.svensson@gmail•com> writes:
> On 5/21/07, Martin Waitz <tali@admingilde•org> wrote:
>> Unify naming of plumbing dirlink/gitlink concept:
>>
>> perl -pi -e 's/dirlink/gitlink/g' -e 's/DIRLNK/GITLINK/g'
>> ---
>
> Does this mean that the link doesn't necessarily has to be represented
> as a directory (even though current code does it) ?
I do not think the patch has that much deep meaning.
Personally I think the patch is similar to renaming "cache" used
in the code to "index" --- needless code shuffling that does not
buy you anything.
As an internal symbol, S_IFDIRLNK makes _much_ more sense than
S_IFGITLINK, exactly because it is a mixture of S_IFDIR and
S_IFLNK.
The only excuse that we _might_ want to consider the patch is
that S_IFDIRLNK has not lived that long, compared to the use of
word "cache" in our codebase. It's only two weeks old -- so if
we were to apply this patch, we would need to do that right
away, or it will be never.
But I am not _so_ enthused about the renaming in the code.
next prev parent reply other threads:[~2007-05-21 23:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 20:08 [PATCH] rename dirlink to gitlink Martin Waitz
2007-05-21 23:12 ` Torgil Svensson
2007-05-21 23:32 ` Junio C Hamano [this message]
2007-05-22 5:59 ` Martin Waitz
2007-05-22 6:19 ` Junio C Hamano
2007-05-22 11:39 ` [PATCH] rename gitlink to dirlink Martin Waitz
2007-05-22 11:53 ` [PATCH] rename dirlink to gitlink Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vodkdbvmk.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=tali@admingilde$(echo .)org \
--cc=torgil.svensson@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox