From: Junio C Hamano <gitster@pobox•com>
To: Peter Jones <pjones@redhat•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] git-am: Handle "git show" output correctly
Date: Wed, 12 Sep 2012 14:18:53 -0700 [thread overview]
Message-ID: <7vpq5raqiq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1347482918.21933.5.camel@eddie.install.bos.redhat.com> (Peter Jones's message of "Wed, 12 Sep 2012 16:48:38 -0400")
Peter Jones <pjones@redhat•com> writes:
> Well, if that happens, maybe we could regexp match on
> "[[:alnum:]_-]+: /someexprthatlookslikeanemailaddress/" ?
I doubt that would be even reliably done.
> But we could
> also just wait to cross that bridge until we get to it?
Not really. If we start encouraging people to use "git show" output
as a kosher input to "am", we would have to support such use
forever, and we end up painting ourselves in a corner we cannot get
out of easily.
next prev parent reply other threads:[~2012-09-12 21:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 15:26 [PATCH] Handle "git show" output correctly Peter Jones
2012-09-12 15:30 ` Peter Jones
2012-09-12 15:41 ` Matthieu Moy
2012-09-12 15:49 ` [PATCH] [git-am] " Peter Jones
2012-09-12 15:57 ` Matthieu Moy
2012-09-12 17:32 ` Junio C Hamano
2012-09-12 18:05 ` Peter Jones
2012-09-12 19:07 ` Junio C Hamano
2012-09-12 15:42 ` [PATCH] " Peter Jones
2012-09-12 15:40 ` Matthieu Moy
2012-09-12 18:00 ` Peter Jones
2012-09-12 18:08 ` [PATCH] git-am: " Peter Jones
2012-09-12 20:06 ` Junio C Hamano
2012-09-12 20:48 ` Peter Jones
2012-09-12 21:03 ` Peter Jones
2012-09-12 21:18 ` Junio C Hamano [this message]
2012-09-12 21:26 ` Dan Johnson
2012-09-12 22:19 ` Junio C Hamano
2012-09-12 22:31 ` Dan Johnson
2012-09-12 23:05 ` Junio C Hamano
2012-09-12 22:41 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpq5raqiq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pjones@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox