From: Junio C Hamano <gitster@pobox•com>
To: Kevin Ballard <kevin@sb•org>
Cc: Git mailing list <git@vger•kernel.org>
Subject: Re: [RFC] Using gitrevisions :/search style with other operators
Date: Mon, 08 Nov 2010 11:09:56 -0800 [thread overview]
Message-ID: <7vpqufpr7f.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <9D675671-693D-4B59-AF2A-0EFE4C537362@sb.org> (Kevin Ballard's message of "Fri\, 5 Nov 2010 15\:38\:23 -0700")
Kevin Ballard <kevin@sb•org> writes:
> There is one operator that doesn't allow this at all, and that's the commit
> message search (e.g. :/foo). Every character after the :/ is taken to be
> part of the regular expression. This is rather unfortunate as it prevents me
> from doing something like :/foo^ to refer to the parent of the matching commit.
>
> Does anybody have any opinions on changing this operator?
If you mean to change what ":/Merge branch 'kb/blame-author-email'" means,
and make my scripts suddenly start breaking, I would be moderately unhappy.
It is fine if we can enhance the extended SHA-1 vocabulary by introducing
a syntax that used to be illegal, hence there is no chance somebody was
using it for other purposes.
I wonder if we can introduce something like ':( ... )' to group things.
E.g.
$ git log 'HEAD..:( :/Merge branch 'kb/blame-author-email' )^2'
I haven't visited the particular codepath for some time, so I don't know
offhand how involved the change would be, though.
next prev parent reply other threads:[~2010-11-08 19:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 22:38 [RFC] Using gitrevisions :/search style with other operators Kevin Ballard
2010-11-08 19:09 ` Junio C Hamano [this message]
2010-11-08 22:11 ` Kevin Ballard
2010-11-09 5:16 ` Jeff King
2010-11-09 15:59 ` Junio C Hamano
2010-11-09 16:08 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2010-11-09 7:30 Yann Dirson
2010-11-09 8:06 ` Kevin Ballard
2010-11-09 9:24 ` Yann Dirson
2010-11-10 0:18 ` Junio C Hamano
2010-11-10 0:33 ` Kevin Ballard
2010-11-10 7:32 ` Yann Dirson
2010-11-10 7:46 ` Kevin Ballard
2010-11-10 7:46 ` Yann Dirson
2010-11-10 15:26 ` Jakub Narebski
2010-11-10 17:23 ` Junio C Hamano
2010-11-10 18:19 ` Jakub Narebski
2010-11-09 16:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpqufpr7f.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kevin@sb$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox