From: Junio C Hamano <gitster@pobox•com>
To: Nicolas Pitre <nico@cam•org>
Cc: Johannes Sixt <j6t@kdbg•org>,
"Shawn O. Pearce" <spearce@spearce•org>,
git@vger•kernel.org, "H. Peter Anvin" <hpa@zytor•com>
Subject: Re: [PATCH] upload-pack: squelch progress indicator if client does not request sideband
Date: Mon, 15 Jun 2009 22:02:43 -0700 [thread overview]
Message-ID: <7vprd4hito.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0906152109240.16467@xanadu.home> (Nicolas Pitre's message of "Mon\, 15 Jun 2009 21\:16\:46 -0400 \(EDT\)")
Nicolas Pitre <nico@cam•org> writes:
>> How did we drive upload-pack over native or ssh connection before we
>> introduced sideband? I vaguely recall that we relied on stderr going
>> to the invoking terminal in the local case. With this change, does
>> the user suddenly stop seeing progress if the client is older than
>> 583b7ea (upload-pack/fetch-pack: support side-band communication,
>> 2006-06-21)? If so, that would be a regression.
>
> Native, or git:// style, certainly never was able to get any kind of
> progress display without sideband support.
>
> As to old clients using ssh... well... that could be a regression. But
> do we really care? This is pre v1.4.1 after all, and even the previous
> Debian stable was using a later git version.
I guess both ssh and local would regress, and we do care about regressions
in general, but I think it is not a grave offense in this case, because
the combination between such an old fetch and the updated upload-pack will
still transfer the objects and will update the refs as expected; only the
progress indication and chatter on the stderr stream will be lost.
So I would say it is Ok to regress in this particular case, _if_ there is
no easy way to avoid it. That was why I asked:
>> I think it is a very good idea to squelch progress output that will never
>> go to the client (it will be wasted traffic, regardless of the "syslog"
>> thing), but
>>
>> (1) Is "not using sideband" the same as "client won't see the progress
>> output" for all vintages of clients that work with the current
>> server?
Stated differently, I think "not using sideband _and_ spawned via daemon"
would be an indication that "the client won't see the progress anyway even
if it were sent." So the question becomes "will it be a small enough
change to detect if the upload-pack is driven by the daemon in the
codepath J6t added 'if (!use_sideband)' to, and if so shouldn't we do so?"
next prev parent reply other threads:[~2009-06-16 5:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 20:38 [PATCH] daemon: send stderr of service programs to the syslog Johannes Sixt
2009-06-15 14:57 ` Shawn O. Pearce
2009-06-15 15:34 ` Nicolas Pitre
2009-06-15 19:06 ` H. Peter Anvin
2009-06-15 21:24 ` [PATCH] upload-pack: squelch progress indicator if client does not request sideband Johannes Sixt
2009-06-15 21:53 ` Junio C Hamano
2009-06-16 1:16 ` Nicolas Pitre
2009-06-16 5:02 ` Junio C Hamano [this message]
2009-06-16 18:03 ` Nicolas Pitre
2009-06-16 18:41 ` Johannes Sixt
2009-06-16 18:57 ` Junio C Hamano
2009-06-16 19:46 ` Nicolas Pitre
2009-06-15 21:39 ` [PATCH] daemon: send stderr of service programs to the syslog Johannes Sixt
2009-06-15 21:43 ` H. Peter Anvin
2009-06-16 20:27 ` Johannes Sixt
2009-06-16 20:30 ` H. Peter Anvin
2009-06-19 20:26 ` Junio C Hamano
2009-06-20 19:25 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprd4hito.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hpa@zytor$(echo .)com \
--cc=j6t@kdbg$(echo .)org \
--cc=nico@cam$(echo .)org \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox