Subject: Re: [PATCH] bisect: error out when given any good rev that is not an ancestor of the bad rev

From: Junio C Hamano <[email-masked]>
Date: Mon, 30 Jun 2008 16:32:00 -0700

Christian Couder <[email-masked]> writes:

> Le mardi 1 juillet 2008, Junio C Hamano a écrit :
>> Christian Couder <[email-masked]> writes:
>> > Before this patch "git bisect" doesn't really work when it is given
>> > some good revs that are siblings of the bad rev.
>> >
>> > For example if there is the following history:
>> >
>> > A-B-C-D
>> >    \E-F
>> >
>> > and we launch "git bisect start D F" then only C and D will be
>> > considered as possible first bad commit.
>
> I am assuming the first bad commit in the graph is A and it is fixed by F.

Ah, I see your confusion here.  bisect is about finding regressions.
"Older ones were good, and now there is a breakage.  Who broke it?"

If F fixed it, that is already outside the bisection's scope.  The user
needs to know that by saying F is good, he is saying he knows everything
that leads to F is good.