From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Johannes Sixt <j.sixt@viscovery•net>,
Ilya Basin <basinilya@gmail•com>,
git@vger•kernel.org
Subject: Re: [PATCH 1/2] git-sh-setup: refactor ident-parsing functions
Date: Mon, 12 Nov 2012 12:32:26 -0800 [thread overview]
Message-ID: <7vr4nyh89x.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121112201235.GA7210@sigill.intra.peff.net> (Jeff King's message of "Mon, 12 Nov 2012 15:12:35 -0500")
Jeff King <peff@peff•net> writes:
> On Mon, Nov 12, 2012 at 12:08:37PM -0800, Junio C Hamano wrote:
>
>> Jeff King <peff@peff•net> writes:
>>
>> > Changing the interface for get_author_ident_from_commit would be a pain,
>> > but if we just wanted to help filter-branch, we could do something like
>> > this:
>>
>> Yes, that is the direction I was alluding to.
>>
>> Callers of get_author_ident_from_commit can also do the same and
>> avoid rebuilding the same $pick_author_script over and over again,
>> or get_author_ident_from_commit can do so for its callers.
>
> I don't think get_author_ident_from_commit can do so on demand due to
> the subshell issue I mentioned.
OK, that is what I obviously missed.
> I wonder if we should simply generate these at build time and store them
> in the script.
Yeah, my knee-jerk reaction was that it was wasteful to run script
at runtime to build a constant string, but the engineering cost may
not be worth it.
next prev parent reply other threads:[~2012-11-12 20:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 6:47 What can cause empty GIT_AUTHOR_NAME for 'git filter-branch --tree-filter' on Solaris? Ilya Basin
2012-10-17 7:18 ` Jeff King
2012-10-17 7:23 ` Johannes Sixt
2012-10-17 8:58 ` Re[2]: " Ilya Basin
2012-10-17 10:36 ` Re[3]: " Ilya Basin
2012-10-17 22:13 ` Jeff King
2012-10-17 22:09 ` Jeff King
2012-10-18 5:31 ` Johannes Sixt
2012-10-18 5:36 ` Jeff King
2012-10-18 6:06 ` Junio C Hamano
2012-10-18 6:08 ` Jeff King
2012-10-18 7:22 ` [PATCH 0/2] clean up filter-branch ident parsing Jeff King
2012-10-18 7:25 ` [PATCH 1/2] git-sh-setup: refactor ident-parsing functions Jeff King
2012-11-12 17:44 ` Junio C Hamano
2012-11-12 19:44 ` Jeff King
2012-11-12 20:08 ` Junio C Hamano
2012-11-12 20:12 ` Jeff King
2012-11-12 20:32 ` Junio C Hamano [this message]
2012-10-18 7:25 ` [PATCH 2/2] filter-branch: use git-sh-setup's ident parsing functions Jeff King
2012-10-18 7:49 ` Johannes Sixt
2012-10-18 7:54 ` Jeff King
2012-10-18 10:22 ` Jeff King
2012-10-18 10:26 ` Jeff King
2012-10-18 10:33 ` [PATCHv2 " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4nyh89x.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=basinilya@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j.sixt@viscovery$(echo .)net \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox