Subject: Re: [PATCH 00/21] git p4: work on cygwin

From: Junio C Hamano <[email-masked]>
Date: Fri, 28 Sep 2012 12:17:40 -0700

Pete Wyckoff <[email-masked]> writes:

> This series fixes problems in git-p4, and its tests, so that
> git-p4 works on the cygwin platform.
>
> See the wiki for info on how to get started on cygwin:
>
>     https://git.wiki.kernel.org/index.php/GitP4
>
> Testing by people who use cygwin would be appreciated.  It would
> be good to support cygwin more regularly.  Anyone who had time
> to contribute to testing on cygwin, and reporting problems, would
> be welcome.
>
> There's more work requried to support msysgit.  Those patches
> are not in good enough shape to ship out yet, but a lot of what
> is in this series is required for msysgit too.
>
> These patches:
>
>     - fix bugs in git-p4 related to issues found on cygwin
>     - cleanup some ugly code in git-p4 observed in error paths while
>       getting tests to work on cygwin
>     - simplify and refactor code and tests to make cygwin changes easier
>     - handle newline and path issues for cygwin platform
>     - speed up some aspects of git-p4 by removing extra shell invocations
>
> Pete Wyckoff (21):
>   git p4: temp branch name should use / even on windows
>   git p4: remove unused imports
>   git p4: generate better error message for bad depot path
>   git p4: fix error message when "describe -s" fails
>   git p4 test: use client_view to build the initial client
>   git p4 test: use client_view in t9806
>   git p4 test: start p4d inside its db dir
>   git p4 test: translate windows paths for cygwin
>   git p4: remove unreachable windows \r\n conversion code
>   git p4: scrub crlf for utf16 files on windows
>   git p4 test: newline handling
>   git p4 test: use LineEnd unix in windows tests too
>   git p4 test: avoid wildcard * in windows
>   git p4: cygwin p4 client does not mark read-only
>   git p4 test: disable chmod test for cygwin
>   git p4: disable read-only attribute before deleting
>   git p4: avoid shell when mapping users
>   git p4: avoid shell when invoking git rev-list
>   git p4: avoid shell when invoking git config --get-all
>   git p4: avoid shell when calling git config
>   git p4: introduce gitConfigBool

Very nicely done.  I was impressed how easy to understand what the
problem each patch attempts to solve is and how it should be solved
only from the description and the changes apparently matched the
description.

I wish patches from everybody looked like these.