public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Ted Ts'o <tytso@mit•edu>
Cc: git@vger•kernel.org, Andi Kleen <ak@linux•intel.com>,
	Clemens Buchacher <drizzd@aon•at>
Subject: Re: [PATCH, RFC] Fix build problems related to profile-directed optimization
Date: Thu, 02 Feb 2012 22:00:37 -0800	[thread overview]
Message-ID: <7vr4ycsbga.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120203020743.GE1032@thunk.org> (Ted Ts'o's message of "Thu, 2 Feb 2012 21:07:43 -0500")

Ted Ts'o <tytso@mit•edu> writes:

> What do you think of this?  I'm still running a test build --- "make
> PROFILE=BUILD all" takes quite a long time, so this is still an RFC; I
> figure there will still be some places where people will point out
> more nits to be polished.  :-)
>
> (In particular, I just noticed I left the V=1 for debugging purposes
> in this version....)

Thanks.

Three comments:

 * I am happy that this version handles this well:

   $ make PROFILE=BUILD install

   even though you did not advertise as such in INSTALL ;-).

 * However, I think "clean" target should remove *.gcda unconditionally.

   $ make PROFILE=BUILD install ; make clean ; git clean -n -x | grep gcda

 * Running "make PROFILE=BUILD install" immediately after another one,
   without "make clean" in between, resulted in full rebuild and test
   before the second "install", which somewhat surprised me.  I however do
   not think this is a big show-stopper problem.

next prev parent reply	other threads:[~2012-02-03  6:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 19:03 [PATCH, RFC] Fix build problems related to profile-directed optimization Theodore Ts'o
2012-02-02 20:02 ` Junio C Hamano
2012-02-02 20:12   ` Ted Ts'o
2012-02-02 20:14     ` Ted Ts'o
2012-02-03  0:58     ` Junio C Hamano
2012-02-03  2:07       ` Ted Ts'o
2012-02-03  6:00         ` Junio C Hamano [this message]
2012-02-03 18:19           ` Theodore Tso
2012-02-03 19:58             ` Junio C Hamano
2012-02-06  0:44               ` [PATCH] " Theodore Ts'o
2012-02-06  4:18                 ` Jeff King
2012-02-06  5:57                   ` Ted Ts'o
2012-02-06  6:00                     ` Theodore Ts'o
2012-02-08 18:53                       ` Ted Ts'o
2012-02-09  4:03                         ` Junio C Hamano
2012-02-09  8:22                         ` Johannes Sixt
2012-02-09 18:22                           ` Junio C Hamano
2012-02-03 18:39           ` [PATCH, RFC] " Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4ycsbga.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=ak@linux$(echo .)intel.com \
    --cc=drizzd@aon$(echo .)at \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tytso@mit$(echo .)edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox