From: Junio C Hamano <gitster@pobox•com>
To: Brandon Casey <casey@nrlssc•navy.mil>
Cc: Jakub Narebski <jnareb@gmail•com>, Werner LEMBERG <wl@gnu•org>,
git@vger•kernel.org, keithp@keithp•com
Subject: Re: serious problem with `git format-patch' & `git am'
Date: Fri, 27 Feb 2009 09:53:50 -0800 [thread overview]
Message-ID: <7vr61jkbpt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <zE3C931NyNaTaadZOgAI_rGf6gmkKr-3ZHRVXh87mHpCMs-0hfnhYg@cipher.nrlssc.navy.mil> (Brandon Casey's message of "Fri, 27 Feb 2009 09:47:49 -0600")
Brandon Casey <casey@nrlssc•navy.mil> writes:
> What does this line do?
>
> git-am.sh line 375:
>
> case "$keep_subject" in -k) SUBJECT="[PATCH] $SUBJECT" ;; esac
>
> It appears to do nothing. It has existed since the beginning of git-am.sh,
> and there has never been another reference to $keep_subject in this script.
> Is it possible that $keep_subject is supposed to be $keep?
I do not think it is doing anything, and I do not think it makes sense to
"fix" it to allow adding "[PATCH] " in front either. I'd vote for
removing the entire thing.
The $keep_subject variable and "add [PATCH] only to later strip" logic was
borrowed from git-applymbox and git-applypatch pair, see 6bff6a6 (Teach
applymbox to keep the Subject: line., 2005-08-16) especially for the
change that affects tools/git-applypatch in the commit. I think there was
a reason that -k refrained from adding the prefix in git-applypatch but
the option to git-am needed to add the prefix which seems inconsistent but
I do not recall the details. Maybe the list archive may know.
next prev parent reply other threads:[~2009-02-27 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 22:03 serious problem with `git format-patch' & `git am' Werner LEMBERG
2009-02-26 10:42 ` Johannes Schindelin
2009-02-26 18:00 ` Brandon Casey
2009-02-27 1:11 ` Jakub Narebski
2009-02-27 2:10 ` Junio C Hamano
2009-02-27 15:47 ` Brandon Casey
2009-02-27 17:53 ` Junio C Hamano [this message]
2009-02-27 9:16 ` Werner LEMBERG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr61jkbpt.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=casey@nrlssc$(echo .)navy.mil \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=keithp@keithp$(echo .)com \
--cc=wl@gnu$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox