From: Junio C Hamano <gitster@pobox•com>
To: Ramkumar Ramachandra <artagnon@gmail•com>
Cc: Git List <git@vger•kernel.org>
Subject: Re: [PATCH] t: don't redefine test_config() in various places
Date: Wed, 20 Mar 2013 11:51:22 -0700 [thread overview]
Message-ID: <7vsj3pewgl.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1363767703-12936-1-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Wed, 20 Mar 2013 13:51:43 +0530")
Ramkumar Ramachandra <artagnon@gmail•com> writes:
> test_config() is already a well-defined function in
> test-lib-functions.sh. Don't duplicate it unnecessarily in:
>
> t4018-diff-funcname.sh
> t7810-grep.sh
> t7811-grep-open.sh
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail•com>
> ---
> Thanks, Junio.
Heh, I've pushed out the original one after fixing them up myself
last night.
next prev parent reply other threads:[~2013-03-20 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 10:43 [PATCH] t7811 (grep-open): remove test_config() redefinition Ramkumar Ramachandra
2013-03-19 16:09 ` Junio C Hamano
2013-03-20 8:21 ` [PATCH] t: don't redefine test_config() in various places Ramkumar Ramachandra
2013-03-20 18:40 ` Jonathan Nieder
2013-03-20 18:51 ` Junio C Hamano [this message]
2013-03-20 19:59 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsj3pewgl.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox