From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org, Emeric Fermas <emeric.fermas@gmail•com>
Subject: Re: [PATCH 0/3] clone --local fixes
Date: Sat, 26 May 2012 23:32:44 -0700 [thread overview]
Message-ID: <7vsjemp20j.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120526034226.GA14287@sigill.intra.peff.net> (Jeff King's message of "Fri, 25 May 2012 23:42:26 -0400")
Jeff King <peff@peff•net> writes:
> Emeric mentioned that he was confused by the behavior of
>
> git clone --local file:///path/to/repo
>
> in that the --local is silently ignored. Looking over the documentation,
> it is quite unclear whether it is supposed to do anything or not.
According to 23d5335 (git clone: do not issue warning while cloning
locally across filesystems, 2007-08-20) and 3d5c418 (git-clone:
aggressively optimize local clone behaviour., 2007-08-01), in the very
early days we only used the local optimization when the end user
explicitly asked for it with the '--local' option.
After 3d5c418f, the option has been made a no-op, because the local-ness
of the $repository parameter, where the definition of the local-ness is
"does 'cd $repository' succeed?", is all that is needed to trigger the
codepath.
The logic to choose the local optimization has since been "is it a path to
a local directory---if so, use the optimizaiton. Otherwise do the usual
URL based thing". And that is why we tell people when they want to try
cloning without local optimization to add "file://" in front of the path.
So your example "file:///" should *not* work even if --local is given,
unless you happen to have a directory called "file:" in your current
directory and it has path/to/repo subdirectory, which is a git repository.
Specifically, the repository at /path/to/repo is not what the command line
is naming.
I think we probably should stop advertising --local in the documentation
and help text.
next prev parent reply other threads:[~2012-05-27 6:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 3:42 [PATCH 0/3] clone --local fixes Jeff King
2012-05-26 3:42 ` [PATCH 1/3] t5701: modernize style Jeff King
2012-05-26 3:45 ` [PATCH 2/3] clone: make --local handle URLs Jeff King
2012-05-28 18:31 ` Johannes Sixt
2012-05-28 19:10 ` Jeff King
2012-05-26 3:45 ` [PATCH 3/3] clone: allow --no-local to turn off local optimizations Jeff King
2012-05-26 4:11 ` [PATCH 4/3] clone: send diagnostic messages to stderr Jeff King
2012-05-27 6:32 ` Junio C Hamano [this message]
2012-05-28 5:36 ` [PATCH 0/3] clone --local fixes Jeff King
2012-05-29 17:43 ` Junio C Hamano
2012-05-30 11:03 ` Jeff King
2012-05-30 11:08 ` Jeff King
2012-05-30 11:09 ` [PATCH 1/2] docs/clone: mention that --local may be ignored Jeff King
2012-05-30 11:10 ` [PATCH 2/2] clone: allow --no-local to turn off local optimizations Jeff King
2012-05-30 17:20 ` Junio C Hamano
2012-05-30 21:59 ` Jeff King
2012-05-30 22:10 ` Junio C Hamano
2012-05-30 23:21 ` Jeff King
2012-05-30 23:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsjemp20j.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=emeric.fermas@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox