From: Junio C Hamano <gitster@pobox•com>
To: Matt Kraai <kraai@ftbfs•org>
Cc: git@vger•kernel.org, Jonathan Nieder <jrnieder@gmail•com>,
Matt Kraai <matt.kraai@amo•abbott.com>
Subject: Re: [PATCH] Makefile: don't run rm without any files
Date: Wed, 13 Feb 2013 08:51:45 -0800 [thread overview]
Message-ID: <7vtxpg9mxq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1360771068-505-1-git-send-email-kraai@ftbfs.org> (Matt Kraai's message of "Wed, 13 Feb 2013 07:57:48 -0800")
Matt Kraai <kraai@ftbfs•org> writes:
> From: Matt Kraai <matt.kraai@amo•abbott.com>
>
> "rm -f -r" fails on QNX when not passed any files to remove.
I do not think it is limited to QNX.
> the clean target, since dep_dirs is empty.
And dep_dirs being empty under some circumstance shouldn't be
limited to QNX, either.
I think your change does no harm, may be a good change if dep_dirs
goes empty, but the justification is lacking. What caused your
dep_dirs to become empty in the first place?
I am scratching my head because I see
OBJECTS := $(LIB_OBJS) $(BUILTIN_OBJS) $(PROGRAM_OBJS) $(TEST_OBJS) \
$(XDIFF_OBJS) \
$(VCSSVN_OBJS) \
git.o
dep_dirs := $(addsuffix .depend,$(sort $(dir $(OBJECTS))))
> Avoid this by merging two rm
> command lines.
>
> Signed-off-by: Matt Kraai <matt.kraai@amo•abbott.com>
> ---
> Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 5a2e02d..c2e3666 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2414,8 +2414,7 @@ clean: profile-clean
> builtin/*.o $(LIB_FILE) $(XDIFF_LIB) $(VCSSVN_LIB)
> $(RM) $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) git$X
> $(RM) $(TEST_PROGRAMS)
> - $(RM) -r bin-wrappers
> - $(RM) -r $(dep_dirs)
> + $(RM) -r bin-wrappers $(dep_dirs)
> $(RM) -r po/build/
> $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
> $(RM) -r $(GIT_TARNAME) .doc-tmp-dir
next prev parent reply other threads:[~2013-02-13 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 15:57 [PATCH] Makefile: don't run rm without any files Matt Kraai
2013-02-13 16:51 ` Junio C Hamano [this message]
2013-02-13 17:00 ` Matt Kraai
2013-02-13 20:01 ` Junio C Hamano
2013-02-13 20:12 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtxpg9mxq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=kraai@ftbfs$(echo .)org \
--cc=matt.kraai@amo$(echo .)abbott.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox