From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH 06/14] introduce credentials API
Date: Fri, 22 Jul 2011 14:42:09 -0700 [thread overview]
Message-ID: <7vtyaevupu.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20110722203901.GA11922@sigill.intra.peff.net
Jeff King <peff@peff•net> writes:
>> > +`credential_reject`::
>> > +
>> > + Inform the credential subsystem that the provided credentials
>> > + have been rejected. This will clear the username and password
>> > + fields in `struct credential`, as well as notify any helpers of
>> > + the rejection (which may, for example, purge the invalid
>> > + credentials from storage).
>>
>> What hints do helpers get when this is called? Do they get username,
>> unique and description to allow them to selectively purge the bad ones
>> while keeping good ones, or the username is already cleared by the time
>> the helpers are notified and they have no clue?
>
> They get username, unique, and description, to let them purge the
> minimal amount (they are always free to ignore the username and purge
> more, of course, if they are backed by less-capable storage).
>
> We could also...
Ahh, that wasn't what I was getting at. I was only reacting to the order
of events described in "clear them, as well as notify" (as if these
cleared information is no longer available to be used to nitify) and
asking for clarification. As long as enough information is sent to the
helper to selectively purge stale/mistyped information so that it can ask
again, I am perfectly happy.
>> The document did not say anything about escaping/quoting of values, but it
>> may not be a bad idea to make it more explicit over there.
>
> There is no quoting or escaping. As the document says, "the value may
> contain any bytes except a newline". It doesn't mention that keys cannot
> contain an "=" or a newline, though that is also true.
This also was a documentation comment; "may contain any bytes" can be
followed with "and used as-is" and I wouldn't have been confused.
Thanks.
next prev parent reply other threads:[~2011-07-22 22:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 7:46 [RFC/PATCH 0/14] less annoying http authentication Jeff King
2011-07-18 7:48 ` [PATCH 01/14] parse-options: add OPT_STRING_LIST helper Jeff King
2011-07-18 7:48 ` [PATCH 02/14] url: decode buffers that are not NUL-terminated Jeff King
2011-07-20 22:16 ` Junio C Hamano
2011-07-18 7:49 ` [PATCH 03/14] improve httpd auth tests Jeff King
2011-07-18 7:49 ` [PATCH 04/14] remote-curl: don't retry auth failures with dumb protocol Jeff King
2011-07-18 7:50 ` [PATCH 05/14] http: retry authentication failures for all http requests Jeff King
2011-07-18 7:50 ` [PATCH 06/14] introduce credentials API Jeff King
2011-07-20 22:17 ` Junio C Hamano
2011-07-22 20:39 ` Jeff King
2011-07-22 21:42 ` Junio C Hamano [this message]
2011-07-22 22:16 ` Jeff King
2011-07-21 21:59 ` Junio C Hamano
2011-07-22 20:40 ` Jeff King
2011-07-18 7:50 ` [PATCH 07/14] http: use credential API to get passwords Jeff King
2011-07-18 7:51 ` [PATCH 08/14] look for credentials in config before prompting Jeff King
2011-07-18 7:51 ` [PATCH 09/14] allow the user to configure credential helpers Jeff King
2011-07-18 7:52 ` [PATCH 10/14] http: use hostname in credential description Jeff King
2011-07-20 22:17 ` Junio C Hamano
2011-07-22 20:47 ` Jeff King
2011-07-22 22:01 ` Junio C Hamano
2011-07-22 22:13 ` Jeff King
2011-08-08 14:37 ` Ted Zlatanov
2011-08-08 17:16 ` Junio C Hamano
2011-08-19 12:01 ` Ted Zlatanov
2011-08-25 20:23 ` Jeff King
2011-08-26 15:29 ` Ted Zlatanov
2011-07-18 7:52 ` [PATCH 11/14] docs: end-user documentation for the credential subsystem Jeff King
2011-07-20 22:17 ` Junio C Hamano
2011-07-18 7:55 ` [PATCH 12/14] credentials: add "cache" helper Jeff King
2011-07-18 7:58 ` [PATCH 13/14] credentials: add "store" helper Jeff King
2011-07-18 7:58 ` [PATCH 14/14] credentials: add "getpass" helper Jeff King
2011-07-18 8:00 ` [RFC/PATCH 0/14] less annoying http authentication Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtyaevupu.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox