From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@github•com>
Cc: Pavel Raiskup <xraisk00@gmail•com>,
Vicent Marti <vicent@github•com>,
git@vger•kernel.org
Subject: Re: Histogram diff, libgit2 enhancement, libgit2 => git merge (GSOC)
Date: Tue, 22 Mar 2011 12:18:48 -0700 [thread overview]
Message-ID: <7vtyevj753.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110322184737.GB22534@sigill.intra.peff.net> (Jeff King's message of "Tue, 22 Mar 2011 14:47:37 -0400")
Jeff King <peff@github•com> writes:
> It may also be necessary to use a mixture of git and libgit2 commands to
> finish tests. For example, a test which is really about checking "log"
> might use "commit", but "commit" hasn't been implemented yet. But it is
> still useful information if we cheat and use regular git's "commit", but
> test the libgit2 log command.
Absolutely, and I don't even think that is "cheating"; it is merely a
natural way to work incrementally.
> As far as which commands to start with, I would start with plumbing
> commands like "update-index", "commit-tree", "update-ref", "rev-list",
> etc. Those are basic building blocks that have reasonably simple
> interfaces, and they're easy to test. And once you start, I think it
> will become more obvious where to go next (because some of the commands
> build on the results of others).
>
>> This probably will lead to some test suite changes, is it truth?
Some tests _might_ depend on implementation detail that we would rather
not, but I don't think there are too many of them, unless you count the
stuff that use "test-<something>" helper binary that link with libgit.a to
make direct calls to the internal. I would suggest to consider a failure
an uncovered bug in the new implementation by default, and discuss the
tests that do depend on the implementation detail of C git on case-by-case
basis to be fixed.
next prev parent reply other threads:[~2011-03-22 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-20 10:55 Histogram diff, libgit2 enhancement, libgit2 => git merge (GSOC) Pavel Raiskup
2011-03-20 18:06 ` Shawn Pearce
2011-03-22 12:32 ` Pavel Raiskup
2011-03-20 18:25 ` Junio C Hamano
2011-03-20 21:01 ` Vicent Marti
2011-03-20 23:44 ` Jeff King
2011-03-21 0:38 ` Vicent Marti
2011-03-22 17:32 ` Pavel Raiskup
2011-03-22 18:47 ` Jeff King
2011-03-22 19:18 ` Junio C Hamano [this message]
2011-03-21 1:27 ` Jonathan Nieder
2011-03-22 16:43 ` Pavel Raiskup
2011-03-23 0:24 ` Vincent van Ravesteijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtyevj753.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@github$(echo .)com \
--cc=vicent@github$(echo .)com \
--cc=xraisk00@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox