From: Junio C Hamano <gitster@pobox•com>
To: Alexander Miseler <alexander@miseler•de>
Cc: git@vger•kernel.org
Subject: Re: [BUG] git-am silently applying patches incorrectly
Date: Fri, 04 Mar 2011 13:33:17 -0800 [thread overview]
Message-ID: <7vtyfi606a.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <loom.20110304T210337-216@post.gmane.org> (Alexander Miseler's message of "Fri\, 4 Mar 2011 20\:14\:01 +0000 \(UTC\)")
Alexander Miseler <alexander@miseler•de> writes:
> It's a bit intimidating for a newbie to chime in on a discussion between the
> creator and the maintainer, but:
> IMHO the biggest problem here isn't the incorrectly, but rather the silently.
> Reducing the chance of guessing incorrectly is good, but git-am still has to
> guess sometimes and it should warn/inform the user when it does that.
(Please don't cull Cc line).
No need to feel intimidated.
The patch under discussion was merely "first things first--let's fix the
obviously wrong case that can be fixed without regression".
Try implementing that warning logic, and using it in real-life projects.
You don't actually have to _code_ it, but merely imagining how it would
work and perform would be sufficient for you to realize that it would be
quite expensive (you need to find all the possible mismatches, essentially
scanning the whole file), and worse yet, it would be annoyingly noisy with
many false positives, because in many real-life projects, end of function
tends to match the problematic pattern that triggered this discussion
quite often even without patches that introduce more of the pattern.
Unless you can reduce the false hits to manageable levels, such a warning
is not very useful (it would be useful as a lame excuse "we warned, but
you took the suspicious result", but that does not help the users).
In short, Linus and I both know what you are talking about, and we may
revisit that issue later, but the thing is that it would not be very
pleasant, and not something that can be done in one sitting during a
single discussion thread on the list.
next prev parent reply other threads:[~2011-03-04 21:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 13:40 [BUG] git-am silently applying patches incorrectly Colin Guthrie
2011-03-04 16:17 ` Drew Northup
2011-03-04 16:41 ` Colin Guthrie
2011-03-04 17:27 ` Junio C Hamano
2011-03-04 17:49 ` Junio C Hamano
2011-03-04 18:37 ` Junio C Hamano
2011-03-04 19:05 ` Junio C Hamano
2011-03-04 19:18 ` Linus Torvalds
2011-03-04 19:31 ` Junio C Hamano
2011-03-04 20:14 ` Alexander Miseler
2011-03-04 21:33 ` Junio C Hamano [this message]
2011-03-04 22:20 ` Colin Guthrie
2011-03-04 22:34 ` Junio C Hamano
2011-03-04 22:42 ` Junio C Hamano
2011-03-05 11:51 ` Colin Guthrie
2011-03-06 22:15 ` Junio C Hamano
2011-03-06 22:40 ` Junio C Hamano
2011-03-06 22:56 ` Jonathan Nieder
[not found] ` <AANLkTikctSrfqKCdeYUyvUmAZjr=i7kaFhPeB-LfwgUz@mail.gmail.com>
2011-03-09 10:31 ` [RFC/PATCH 0/2] i18n: add ngettext stub Jonathan Nieder
2011-03-09 10:46 ` [PATCH 1/2] i18n: add stub ngettext implementation Jonathan Nieder
2011-03-09 10:52 ` [PATCH 2/2] i18n: avoid conflict with ngettext from libintl Jonathan Nieder
2011-03-09 20:43 ` Junio C Hamano
2011-03-09 20:51 ` Jonathan Nieder
2011-03-09 20:55 ` Junio C Hamano
2011-03-10 3:17 ` [PATCH v2] i18n: add stub Q_() wrapper for ngettext Jonathan Nieder
2011-03-10 7:59 ` Junio C Hamano
2011-03-10 9:24 ` Ævar Arnfjörð Bjarmason
2011-03-10 9:21 ` [PATCH 2/2] i18n: avoid conflict with ngettext from libintl Ævar Arnfjörð Bjarmason
2011-03-06 22:15 ` [BUG] git-am silently applying patches incorrectly Junio C Hamano
2011-03-07 9:37 ` Colin Guthrie
2011-03-04 23:09 ` Alexander Miseler
2011-03-05 0:05 ` Junio C Hamano
2011-03-04 22:58 ` Junio C Hamano
2011-03-04 21:49 ` Drew Northup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtyfi606a.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=alexander@miseler$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox