From: Junio C Hamano <gitster@pobox•com>
To: Stephen Boyd <bebarino@gmail•com>
Cc: "Shawn O. Pearce" <spearce@spearce•org>,
git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCHv2 2/2] completion: complete config variables for --get/getall/unset/unset-all
Date: Tue, 12 May 2009 01:12:14 -0700 [thread overview]
Message-ID: <7vtz3q91up.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4A09071A.1030107@gmail.com> (Stephen Boyd's message of "Mon\, 11 May 2009 22\:20\:26 -0700")
Stephen Boyd <bebarino@gmail•com> writes:
> Shawn O. Pearce wrote:
>> These probably could have been one patch, since the function
>> is introduced only to support this one usage, and this patch
>> is only 4 lines larger than the function definition anyway...
>
> Seeing that this hasn't been picked up yet, I'm fine with this being
> squashed into one commit. Could you use this combination of the two
> messages for the commit?
>
> ---8<----
>
> Subject: completion: complete config variables for
> --get/getall/unset/unset-all
Hmm, shouldn't this just be
Subject: completion: complete variable names for "git config" command
?
next prev parent reply other threads:[~2009-05-12 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 1:23 [PATCHv2 0/2] completion: config --unset/get Stephen Boyd
2009-05-09 1:23 ` [PATCHv2 1/2] completion: add __git_config_get_set_variables() to get config variables Stephen Boyd
2009-05-09 1:23 ` [PATCHv2 2/2] completion: complete config variables for --get/getall/unset/unset-all Stephen Boyd
2009-05-09 3:44 ` Shawn O. Pearce
2009-05-12 5:20 ` Stephen Boyd
2009-05-12 8:12 ` Junio C Hamano [this message]
2009-05-12 19:05 ` Stephen Boyd
2009-05-13 18:33 ` Junio C Hamano
2009-05-13 18:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtz3q91up.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=bebarino@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox