Subject: Re: [PATCH] t9301-fast-export.sh: don't unset config variable while we're skipping test 4

From: Junio C Hamano <[email-masked]>
Date: Mon, 18 Aug 2008 17:32:45 -0700

Brandon Casey <[email-masked]> writes:

> ---
>
>
> This is necessary if t9301.4 is included in the GIT_SKIP_TESTS
> environment variable.

If it is not skipped what happens?  Does your change break this test?

How about attempting to unset always (because the test does not want to
have the configuration) but ignore the result from the command (because
the config may not have had anything to unset to begin with depending on
what happened in the previous tests)?

>  t/t9301-fast-export.sh |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9301-fast-export.sh b/t/t9301-fast-export.sh
> index c19b4a2..475aadd 100755
> --- a/t/t9301-fast-export.sh
> +++ b/t/t9301-fast-export.sh
> @@ -190,7 +190,6 @@ export GIT_COMMITTER_NAME='C O Mitter'
>  
>  test_expect_success 'setup copies' '
>  
> -	git config --unset i18n.commitencoding &&
>  	git checkout -b copy rein &&
>  	git mv file file3 &&
>  	git commit -m move1 &&
> -- 
> 1.6.0.13.ge1c8