Subject: Re: [PATCH 2/8] wildmatch: rename constants and update prototype

From: Junio C Hamano <[email-masked]>
Date: Wed, 26 Dec 2012 10:44:43 -0800

Nguyễn Thái Ngọc Duy  <[email-masked]> writes:

> @@ -134,101 +131,102 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case)
>  				p_ch = NEGATE_CLASS;
>  #endif
>  			/* Assign literal TRUE/FALSE because of "matched" comparison. */
> -			special = p_ch == NEGATE_CLASS? TRUE : FALSE;
> +			special = p_ch == NEGATE_CLASS;

Leftover comment needs to be reworded as well???

>  			if (special) {
>  				/* Inverted character class. */
>  				p_ch = *++p;
>  			}

I'd prefer "special" used in the "case '['" given a more sensible
name here.