From: Junio C Hamano <gitster@pobox•com>
To: Miklos Vajna <vmiklos@frugalware•org>
Cc: Matthew Cline <matt@nightrealms•com>, git@vger•kernel.org
Subject: Re: git-commit feature request: pass editor command line options
Date: Wed, 14 Oct 2009 12:11:28 -0700 [thread overview]
Message-ID: <7vvdihdc4f.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20091014172337.GE6115@genesis.frugalware.org> (Miklos Vajna's message of "Wed\, 14 Oct 2009 19\:23\:38 +0200")
Miklos Vajna <vmiklos@frugalware•org> writes:
> On Tue, Oct 13, 2009 at 09:58:51PM -0700, Matthew Cline <matt@nightrealms•com> wrote:
>>
>> I'd like to be able to have git-commit pass the commit-message editor command
>> line options which aren't passed to the editor for other usages. Right now
>> I have "co" aliased to "!sh -c 'GIT_EDITOR=git-commit-editor git commit'",
>> where git-commit-editor is a wrapper around my editor-of-choice which passes
>> the editor the command line options I want, but it'd be simpler and cleaner
>> if I could just set "commit.editor_options=-BAR". Or even let there be a
>> separate editor for commits, so I could do "core.editor=foo" and
>> "commit.editor=foo -BAR".
>
> Hmm, what is the use-case when using an option --foo is useful when
> creating a commit, but not useful when crating a tag?
>
> Apart from introducing inconsistency...
Not between commit and tag, but I can see you may want to auto-wrap for
log message but forbid auto-wrap when editing rebase insn sheet during
"rebase -i".
next prev parent reply other threads:[~2009-10-14 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 4:58 git-commit feature request: pass editor command line options Matthew Cline
2009-10-14 17:23 ` Miklos Vajna
2009-10-14 19:11 ` Junio C Hamano [this message]
2009-10-14 21:12 ` Jeff King
2009-10-14 20:03 ` Matthew Cline
2009-10-14 22:12 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdihdc4f.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=matt@nightrealms$(echo .)com \
--cc=vmiklos@frugalware$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox