Subject: Re: [PATCH v2] cat-file --batch / --batch-check: do not exit if hashes are missing

From: Junio C Hamano <[email-masked]>
Date: Mon, 09 Jun 2008 13:42:57 -0700

Lea Wiemann <[email-masked]> writes:

> diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
> index 973aef7..542b4ae 100755
> --- a/t/t1006-cat-file.sh
> +++ b/t/t1006-cat-file.sh
> @@ -174,9 +174,27 @@ do
> ...
> +foobar84 missing" = \
> +    "$(( echo foobar42; echo_without_newline foobar84; ) | git cat-file --batch-check)"

I have a slight suspicion that some of the Bourne shell implementations we
support may misinterpret $(( as beginning of arithmetic expansion, so
perhaps we would want an extra SP between the open parens.

Other than that, looked ok.