public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <junkio@cox•net>
To: Andy Parkins <andyparkins@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/2] cvsserver: Remove trailing "\n" from commithash in checkin function
Date: Tue, 27 Feb 2007 15:45:49 -0800	[thread overview]
Message-ID: <7vwt239nbm.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200702271249.09596.andyparkins@gmail.com> (Andy Parkins's message of "Tue, 27 Feb 2007 12:49:09 +0000")

Andy Parkins <andyparkins@gmail•com> writes:

> The commithash for updating the ref is obtained from a call to
> git-commit-tree.  However, it was returned (and stored) with the
> trailing newline.  This meant that the later call to git-update-ref that
> was trying to update to $commithash was including the newline in the
> parameter - obviously that hash would never exist, and so git-update-ref
> would always fail.
>
> The solution is to chomp() the commithash as soon as it is returned by
> git-commit-tree.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail•com>
>      my $commithash = `git-commit-tree $treehash -p $parenthash < $msg_filename`;
> +	chomp($commithash);
>      $log->info("Commit hash : $commithash");
>  

Thanks.  Do we need to compensate with a trailing LF in the $log
line?

next prev parent reply	other threads:[~2007-02-27 23:45 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20  7:28 Unresolved issues Junio C Hamano
     [not found] ` <Pine.LNX.4.64.07022009 34270.20368@woody.linux-foundation.org>
2007-02-20  8:57 ` Andy Parkins
2007-02-20 20:10   ` [PATCH] Use git-update-ref to update a ref during commit in git-cvsserver Andy Parkins
2007-02-20 21:57     ` Nicolas Pitre
2007-02-21  5:54     ` Junio C Hamano
2007-02-21  9:08       ` Andy Parkins
2007-02-27 12:48         ` [PATCH 1/2] Make 'cvs ci' lockless in git-cvsserver by using git-update-ref Andy Parkins
2007-02-27 13:55           ` Jakub Narebski
2007-02-27 14:35           ` Nicolas Pitre
2007-02-27 23:44           ` Junio C Hamano
2007-02-28  8:44             ` Andy Parkins
2007-02-28 18:06               ` Junio C Hamano
2007-02-27 12:49         ` [PATCH 2/2] cvsserver: Remove trailing "\n" from commithash in checkin function Andy Parkins
2007-02-27 23:45           ` Junio C Hamano [this message]
2007-02-28  8:45             ` Andy Parkins
2007-02-27 23:37       ` [PATCH] Use git-update-ref to update a ref during commit in git-cvsserver Martin Langhoff
2007-02-20 17:41 ` Unresolved issues Linus Torvalds
2007-02-20 21:43   ` Junio C Hamano
2007-02-21  0:21     ` Linus Torvalds
2007-02-21  0:25       ` Junio C Hamano
2007-02-21  0:39       ` Johannes Schindelin
2007-02-21  0:56         ` Linus Torvalds
2007-02-21  0:51           ` David Lang
2007-02-21  1:12           ` Johannes Schindelin
2007-02-21  1:51           ` Nicolas Pitre
2007-02-21  2:03             ` Linus Torvalds
2007-02-21 16:32           ` Robin Rosenberg
2007-02-21  1:49         ` Theodore Tso
2007-02-21 10:42         ` Martin Waitz
2007-02-21 12:55           ` Johannes Schindelin
2007-02-21 16:57             ` Brian Gernhardt
2007-02-21 17:05               ` Shawn O. Pearce
2007-02-22  8:28 ` [PATCH] git-status: do not be totally useless in a read-only repository Junio C Hamano
2007-02-22  8:30   ` [PATCH] update-index: do not die too early " Junio C Hamano
2007-02-26  1:33 ` Unresolved issues Julian Phillips
2007-02-26  3:39   ` Junio C Hamano
2007-02-26  5:10     ` Julian Phillips
2007-02-26  5:33       ` Junio C Hamano
2007-02-27 20:10   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwt239nbm.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox$(echo .)net \
    --cc=andyparkins@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox