From: Junio C Hamano <gitster@pobox•com>
To: Heiko Voigt <hvoigt@hvoigt•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] fix sample update hook, disable overwriting of existing tags
Date: Thu, 07 May 2009 17:05:49 -0700 [thread overview]
Message-ID: <7vzldobgrm.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20090507164023.GB5807@macbook.lan
Heiko Voigt <hvoigt@hvoigt•net> writes:
> Because no special rule for this existed it was allowed by default
I do not disagree that it is a good thing to be able to reject
overwriting, but I do not think it is a _fix_. allowdeletetag is about
_deletion_ and it already is covered by the code, isn't it?
I think it would make more sense to introduce $allowmodifytag and reject
such pushes in the codepath you touched.
next prev parent reply other threads:[~2009-05-08 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 16:40 [PATCH] fix sample update hook, disable overwriting of existing tags Heiko Voigt
2009-05-08 0:05 ` Junio C Hamano [this message]
2009-05-08 15:22 ` [PATCH v2] Extend sample update hook, disable modifying " Heiko Voigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzldobgrm.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hvoigt@hvoigt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox