Subject: Re: [PATCH v2 7/8] merge-ort: skip rename detection entirely if possible

From: Derrick Stolee <[email-masked]>
Date: Tue, 9 Mar 2021 17:51:57 -0500

On 3/8/2021 7:09 PM, Elijah Newren via GitGitGadget wrote:> +	goto simple_cleanup; /* collect_renames() handles some of cleanup */
> +
> +cleanup:
> +	/*
> +	 * Free now unneeded filepairs, which would have been handled
> +	 * in collect_renames() normally but we're about to skip that
> +	 * code...
> +	 */

"but we're about to skip that code"

Haven't you skipped it already, earlier in the above part? This should
instead say "but we skipped that code", right?

Thanks,
-Stolee