From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo•com>
To: "Torsten Bögershausen" <tboegi@web•de>,
"Alexandr Miloslavskiy via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH v2 1/2] t0028: fix test for UTF-16-LE-BOM
Date: Tue, 24 Sep 2019 11:53:39 +0200 [thread overview]
Message-ID: <847a5ce7-0228-501b-e753-1688c4a24b01@syntevo.com> (raw)
In-Reply-To: <20190924034611.6bsy627udlzgxuv2@tb-raspi4>
On 24.09.2019 5:46, Torsten Bögershausen wrote:
> Out of curiosity:
> What made the test fail, and does it pass noe ?
It failed to a bug in Windows Debug build, which caused iconv() to fail
in most cases, see:
https://public-inbox.org/git/pull.348.git.gitgitgadget@gmail.com/
> How about the following:
Sure thing, I will use the wording you suggested.
next prev parent reply other threads:[~2019-09-24 10:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:33 [PATCH 0/2] t0028 fix test + more tests Alexandr Miloslavskiy via GitGitGadget
2019-09-23 8:33 ` [PATCH 1/2] t0028: fix test for UTF-16-LE-BOM Alexandr Miloslavskiy via GitGitGadget
2019-09-23 8:33 ` [PATCH 2/2] t0028: add more tests Alexandr Miloslavskiy via GitGitGadget
2019-09-23 10:04 ` [PATCH v2 0/2] Update: fixed typos in commit message Alexandr Miloslavskiy via GitGitGadget
2019-09-23 10:04 ` [PATCH v2 1/2] t0028: fix test for UTF-16-LE-BOM Alexandr Miloslavskiy via GitGitGadget
2019-09-24 3:46 ` Torsten Bögershausen
2019-09-24 9:53 ` Alexandr Miloslavskiy [this message]
2019-09-23 10:04 ` [PATCH v2 2/2] t0028: add more tests Alexandr Miloslavskiy via GitGitGadget
2019-09-24 4:06 ` Torsten Bögershausen
2019-09-24 10:03 ` Alexandr Miloslavskiy
2019-09-24 6:21 ` Johannes Sixt
2019-09-24 10:31 ` Alexandr Miloslavskiy
2019-09-24 10:40 ` [PATCH v3 0/2] Update: fixed typos in commit message Alexandr Miloslavskiy via GitGitGadget
2019-09-24 10:40 ` [PATCH v3 1/2] t0028: fix test for UTF-16-LE-BOM Alexandr Miloslavskiy via GitGitGadget
2019-09-24 10:40 ` [PATCH v3 2/2] t0028: add more tests Alexandr Miloslavskiy via GitGitGadget
2019-09-28 4:47 ` Junio C Hamano
2019-09-30 7:26 ` Alexandr Miloslavskiy
2019-09-26 19:37 ` [PATCH v3 0/2] Update: fixed typos in commit message Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=847a5ce7-0228-501b-e753-1688c4a24b01@syntevo.com \
--to=alexandr.miloslavskiy@syntevo$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox