From: merlyn@stonehenge•com (Randal L. Schwartz)
To: Junio C Hamano <junkio@cox•net>
Cc: git@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [BUG] daemon.c blows up on OSX
Date: 20 Dec 2006 14:46:57 -0800 [thread overview]
Message-ID: <86ac1iyyla.fsf@blue.stonehenge.com> (raw)
In-Reply-To: <86ejquyz4v.fsf@blue.stonehenge.com>
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
>>>>> "Randal" == Randal L Schwartz <merlyn@stonehenge•com> writes:
Randal> running "git version 1.4.4.3.g5485" on my openbsd box, but I can't get
Randal> there on my OSX box.
According to my headers, "strncasecmp" is defined in <string.h>,
"NI_MAXSERV" is defined in <netdb.h>, and "initgrps" is defined
in "unistd.h". So this patch works (just verified on OSX), but I
don't know what damage it does elsehwere:
diff --git a/daemon.c b/daemon.c
index b129b83..5ce73ed 100644
--- a/daemon.c
+++ b/daemon.c
@@ -1,3 +1,7 @@
+#include <string.h>
+#include <netdb.h>
+#include <unistd.h>
+
#include "cache.h"
#include "pkt-line.h"
#include "exec_cmd.h"
However, now imap-send.o blows up:
imap-send.c: In function 'imap_open_store':
imap-send.c:908: error: 'AF_LOCAL' undeclared (first use in this function)
imap-send.c:908: error: (Each undeclared identifier is reported only once
imap-send.c:908: error: for each function it appears in.)
imap-send.c:990: warning: implicit declaration of function 'getpass'
imap-send.c:990: warning: assignment makes pointer from integer without a cast
make: *** [imap-send.o] Error 1
and finding "getpass" wants me to add "unistd.h" there too.
Hmm. Let's see if I can use git-format-patch as Linus intended.
[-- Attachment #2: patch for osx --]
[-- Type: text/plain, Size: 852 bytes --]
From 1549561dc68a1ea71f137c40109c90d33c0f9887 Mon Sep 17 00:00:00 2001
From: Randal L. Schwartz <merlyn@4•sub-70-192-166.myvzw.com>
Date: Wed, 20 Dec 2006 14:45:49 -0800
Subject: [PATCH] patch for osx
---
daemon.c | 4 ++++
imap-send.c | 2 ++
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/daemon.c b/daemon.c
index b129b83..5ce73ed 100644
--- a/daemon.c
+++ b/daemon.c
@@ -1,3 +1,7 @@
+#include <string.h>
+#include <netdb.h>
+#include <unistd.h>
+
#include "cache.h"
#include "pkt-line.h"
#include "exec_cmd.h"
diff --git a/imap-send.c b/imap-send.c
index 894cbbd..afd7447 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -22,6 +22,8 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
+#include <unistd.h>
+
#include "cache.h"
typedef struct store_conf {
--
1.4.4.3.g5485-dirty
[-- Attachment #3: Type: text/plain, Size: 291 bytes --]
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge•com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!
next prev parent reply other threads:[~2006-12-20 22:47 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 20:48 What's in git.git (stable), and Announcing GIT 1.4.4.3 Junio C Hamano
2006-12-20 22:04 ` Randal L. Schwartz
2006-12-20 22:14 ` Linus Torvalds
2006-12-20 22:20 ` [BUG] daemon.c blows up on OSX (was Re: What's in git.git (stable), and Announcing GIT 1.4.4.3) Randal L. Schwartz
2006-12-20 22:25 ` [BUG] daemon.c blows up on OSX Junio C Hamano
2006-12-20 22:35 ` Randal L. Schwartz
2006-12-20 22:44 ` Junio C Hamano
2006-12-20 22:46 ` Randal L. Schwartz [this message]
2006-12-20 23:03 ` Junio C Hamano
2006-12-20 23:25 ` Randal L. Schwartz
2006-12-20 23:34 ` Randal L. Schwartz
2006-12-21 2:04 ` Stefan Pfetzing
2006-12-20 23:07 ` Linus Torvalds
2006-12-20 23:17 ` Randal L. Schwartz
2006-12-20 23:30 ` Junio C Hamano
2006-12-20 23:41 ` Linus Torvalds
2006-12-21 0:36 ` Terje Sten Bjerkseth
2006-12-21 0:44 ` Junio C Hamano
2006-12-21 0:54 ` Terje Sten Bjerkseth
2006-12-21 1:00 ` Junio C Hamano
2006-12-21 1:20 ` Randal L. Schwartz
2006-12-21 1:29 ` Junio C Hamano
2006-12-21 1:35 ` Terje Sten Bjerkseth
2006-12-21 10:39 ` [PATCH] Do not define _XOPEN_SOURCE on MacOSX as it is too restricting there Marco Roeland
2006-12-21 11:28 ` [PATCH] Don't define _XOPEN_SOURCE on MacOSX and FreeBSD as it is too restricting Marco Roeland
2006-12-22 0:52 ` Junio C Hamano
2006-12-22 1:04 ` Shawn Pearce
2006-12-22 6:53 ` Rocco Rutte
2006-12-22 7:51 ` Marco Roeland
2006-12-22 8:37 ` Junio C Hamano
2006-12-22 11:47 ` Marco Roeland
2006-12-22 12:55 ` Rocco Rutte
2006-12-22 13:14 ` Marco Roeland
2007-01-03 15:25 ` [BUG] daemon.c blows up on OSX Andreas Ericsson
2006-12-21 0:44 ` Linus Torvalds
2006-12-21 1:07 ` Randal L. Schwartz
2006-12-21 1:13 ` Junio C Hamano
2006-12-21 1:08 ` Randal L. Schwartz
[not found] ` <24BF45E9-DD98-4609-9D65-B01EAA30CCA8@silverinsanity.com>
2006-12-21 1:35 ` Randal L. Schwartz
2006-12-21 1:48 ` Junio C Hamano
2006-12-21 1:50 ` Randal L. Schwartz
2006-12-21 1:57 ` Junio C Hamano
2006-12-20 23:58 ` What's in git.git (stable), and Announcing GIT 1.4.4.3 Randal L. Schwartz
2006-12-20 22:17 ` Junio C Hamano
2006-12-21 8:43 ` Johannes Schindelin
2006-12-21 8:52 ` Junio C Hamano
2006-12-20 22:19 ` Nicolas Pitre
2006-12-21 11:38 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2006-12-21 0:56 [BUG] daemon.c blows up on OSX Brian Gernhardt
2006-12-21 2:52 Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ac1iyyla.fsf@blue.stonehenge.com \
--to=merlyn@stonehenge$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox