From: Kjetil Barvik <barvik@broadpark•no>
To: Alex Riesen <raa.lkml@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH] check_updates(): effective removal of cache entries marked CE_REMOVE
Date: Thu, 19 Feb 2009 10:06:59 +0100 [thread overview]
Message-ID: <86ocwy3ido.fsf@broadpark.no> (raw)
In-Reply-To: <81b0412b0902190024t3fc7ab20r9a23c72270ac1033@mail.gmail.com>
Alex Riesen <raa.lkml@gmail•com> writes:
> 2009/2/18 Kjetil Barvik <barvik@broadpark•no>:
>> If we can trust the numbers from oprofile in this case, we saved
>> approximately ((7710 - 46) * 20000) / (2 * 1000 * 1000 * 1000) = 0.077
>> seconds CPU time with this fix for this particular test. And notice
>> that now the CPU did only 46 / 15 = 3.1 cycles/instruction.
> ...
>> diff --git a/unpack-trees.c b/unpack-trees.c
>> index e3c3fa1..273b5da 100644
>> --- a/unpack-trees.c
>> +++ b/unpack-trees.c
>> @@ -93,11 +93,9 @@ static int check_updates(struct unpack_trees_options *o)
>> display_progress(progress, ++cnt);
>> if (o->update)
>> unlink_entry(ce);
>> - remove_index_entry_at(&o->result, i);
>> - i--;
>> - continue;
>> }
>> }
>> + remove_marked_cache_entries(&o->result);
>> remove_scheduled_dirs();
>>
>
> What commit is this change based on? It does not apply to any
> of Junio's master, next, or pu...
It was based on 'pu', and not a uptodate one. Sorry about that, I
will update the patch based on master, and include it together with
the 2 'USE_NSEC'-patches, which I posted some few days ago.
-- kjetil
next prev parent reply other threads:[~2009-02-19 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 22:18 [PATCH] check_updates(): effective removal of cache entries marked CE_REMOVE Kjetil Barvik
2009-02-18 22:44 ` Linus Torvalds
2009-02-19 8:24 ` Alex Riesen
2009-02-19 9:06 ` Kjetil Barvik [this message]
2009-02-20 7:41 ` Junio C Hamano
2009-02-20 9:01 ` Kjetil Barvik
2009-02-20 9:14 ` Johannes Schindelin
2009-02-20 10:15 ` Kjetil Barvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ocwy3ido.fsf@broadpark.no \
--to=barvik@broadpark$(echo .)no \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=raa.lkml@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox