public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Kjetil Barvik <barvik@broadpark•no>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH] Makefile: turn on USE_ST_TIMESPEC for FreeBSD
Date: Sun, 22 Mar 2009 15:15:57 +0100	[thread overview]
Message-ID: <86skl5d4o2.fsf@broadpark.no> (raw)
In-Reply-To: <20090322080847.GA9075@coredump.intra.peff.net>

Jeff King <peff@peff•net> writes:

> Fixes broken compilation on FreeBSD 6.1.
>
> Signed-off-by: Jeff King <peff@peff•net>
> ---
> No idea if older versions support this, or if they just need NO_NSEC
> instead.

  I google'd a litle and found this:

    http://fuse4bsd.creo.hu/localcgi/man-cgi.cgi?lstat+2
    http://www.nabble.com/st_mtimespec-or-st_mtime--td21217981.html

  So, at least FreeBSD 6.2 also seems to need this.  And I suspect that
  OpenBSD and/or NetBSD maybe need a simmilar patch.  Anybody who can
  test this?

  -- kjetil

>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index aae3b09..320c897 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -713,6 +713,7 @@ ifeq ($(uname_S),FreeBSD)
>  	BASIC_CFLAGS += -I/usr/local/include
>  	BASIC_LDFLAGS += -L/usr/local/lib
>  	DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
> +	USE_ST_TIMESPEC = YesPlease
>  	THREADED_DELTA_SEARCH = YesPlease
>  	ifeq ($(shell expr "$(uname_R)" : '4\.'),2)
>  		PTHREAD_LIBS = -pthread

     prev parent reply	other threads:[~2009-03-22 14:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22  8:08 [PATCH] Makefile: turn on USE_ST_TIMESPEC for FreeBSD Jeff King
2009-03-22 14:15 ` Kjetil Barvik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86skl5d4o2.fsf@broadpark.no \
    --to=barvik@broadpark$(echo .)no \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox