From: merlyn@stonehenge•com (Randal L. Schwartz)
To: "Joakim Tjernlund" <joakim.tjernlund@transmode•se>
Cc: <git@vger•kernel.org>
Subject: Re: git-svn and u-boot broken.
Date: 13 Oct 2006 12:39:48 -0700 [thread overview]
Message-ID: <86slhsgg3f.fsf@blue.stonehenge.com> (raw)
In-Reply-To: <00ad01c6eefc$84298280$1267a8c0@Jocke>
>>>>> "Joakim" == Joakim Tjernlund <joakim.tjernlund@transmode•se> writes:
Joakim> First, I had to change this (from memory) in git-svn:
Joakim> my $got = SVN::TxDelta::send_stream($fh, @$atd, $self->{pool});
Joakim> to
Joakim> my $got;
Joakim> if ( $got ) {
Joakim> $got = SVN::TxDelta::send_stream($fh, @$atd, $self->{pool});
Joakim> } else {
Joakim> $got = $exp
Joakim> }
Joakim> I am no perl programmer so please change as you se fit.
That doesn't make any sense. You'll never run the if-true branch there.
The value of $got immediately following "my $got;" is always undef.
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge•com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!
next prev parent reply other threads:[~2006-10-13 19:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 19:19 git-svn and u-boot broken Joakim Tjernlund
2006-10-13 19:39 ` Randal L. Schwartz [this message]
2006-10-13 19:43 ` Joakim Tjernlund
2006-10-14 1:21 ` Joakim Tjernlund
2006-10-14 6:28 ` Eric Wong
2006-10-14 9:51 ` Joakim Tjernlund
2006-10-14 22:46 ` Eric Wong
2006-10-14 22:48 ` [PATCH] git-svn: reduce memory usage for large commits Eric Wong
2006-10-14 23:54 ` git-svn and u-boot broken Joakim Tjernlund
-- strict thread matches above, loose matches on Subject: below --
2006-10-14 13:13 Joakim Tjernlund
2006-10-14 21:09 ` Eric Wong
2006-10-15 0:39 ` Joakim Tjernlund
2006-10-15 1:48 ` Eric Wong
2006-10-15 2:10 ` Joakim Tjernlund
2006-10-15 22:09 Joakim Tjernlund
2006-10-16 3:47 ` Eric Wong
2006-10-16 10:06 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86slhsgg3f.fsf@blue.stonehenge.com \
--to=merlyn@stonehenge$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=joakim.tjernlund@transmode$(echo .)se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox