Subject: Re: [PATCH v2 2/2] convert: Stream from fd to required clean filter instead of mmap

From: Andreas Schwab <[email-masked]>
Date: Sun, 17 Aug 2014 13:03:43 +0200

Steffen Prohaska <[email-masked]> writes:

> On Aug 16, 2014, at 7:00 PM, Andreas Schwab <[email-masked]> wrote:
>
>> Steffen Prohaska <[email-masked]> writes:
>> 
>>> The test should confirm that the the file that is added is not mmapped to
>>> memory.
>> 
>> RSS doesn't tell you that.  You can mmap a big file without RSS getting
>> bigger.
>
> All data are accessed after mapping, so RSS should be fine.

RSS can shink any time when memory is tight.

> The test always did what I expected.

Not a sufficient condition.

Andreas.

-- 
Andreas Schwab, [email-masked]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."