From: Teemu Likonen <tlikonen@iki•fi>
To: Nanako Shiraishi <nanako3@lavabit•com>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>,
Junio C Hamano <gitster@pobox•com>,
felipe.contreras@gmail•com,
"Shawn O. Pearce" <spearce@spearce•org>
Subject: [PATCH] bash completion: add --format= and --oneline options for "git log"
Date: Tue, 24 Feb 2009 13:02:16 +0200 [thread overview]
Message-ID: <871vtonlmv.fsf_-_@iki.fi> (raw)
In-Reply-To: <20090224185913.6117@nanako3.lavabit.com> (Nanako Shiraishi's message of "Tue\, 24 Feb 2009 18\:59\:13 +0900")
Signed-off-by: Teemu Likonen <tlikonen@iki•fi>
---
I like this change and would immediately switch to using --format= and
--oneline instead of --pretty=. I think we should add these bash
completions too.
contrib/completion/git-completion.bash | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 0a3092f..34396c2 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1012,10 +1012,15 @@ _git_log ()
--pretty=*)
__gitcomp "$__git_log_pretty_formats
" "" "${cur##--pretty=}"
return
;;
+ --format=*)
+ __gitcomp "$__git_log_pretty_formats
+ " "" "${cur##--format=}"
+ return
+ ;;
--date=*)
__gitcomp "
relative iso8601 rfc2822 short local default
" "" "${cur##--date=}"
return
@@ -1028,10 +1033,12 @@ _git_log ()
--root --topo-order --date-order --reverse
--follow
--abbrev-commit --abbrev=
--relative-date --date=
--pretty=
+ --format=
+ --oneline
--cherry-pick
--graph
--decorate
--walk-reflogs
--parents --children
--
1.6.2.rc1.29.g79ccf
next prev parent reply other threads:[~2009-02-24 11:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 15:26 [RFC/PATCH] revision.c: add --format option for 'git log' Felipe Contreras
2009-02-22 16:49 ` Junio C Hamano
2009-02-22 17:18 ` Felipe Contreras
2009-02-22 17:53 ` Junio C Hamano
2009-02-22 18:06 ` Junio C Hamano
2009-02-22 18:14 ` Felipe Contreras
2009-02-22 18:37 ` Junio C Hamano
2009-02-22 18:55 ` Felipe Contreras
2009-02-23 6:39 ` Junio C Hamano
2009-02-24 0:56 ` Felipe Contreras
2009-02-24 1:03 ` Felipe Contreras
2009-02-24 1:33 ` Junio C Hamano
2009-02-24 1:55 ` Nanako Shiraishi
2009-02-24 8:00 ` Junio C Hamano
2009-02-24 9:34 ` Felipe Contreras
2009-02-24 4:06 ` [PATCH] Add --format that is a synonym to --pretty Nanako Shiraishi
2009-02-24 4:50 ` Jeff King
2009-02-24 5:33 ` Junio C Hamano
2009-02-24 5:45 ` Jeff King
2009-02-24 9:59 ` [PATCH 0/3] --format, --pretty and --oneline Nanako Shiraishi
2009-02-24 9:59 ` [PATCH 1/3] Add --format that is a synonym to --pretty Nanako Shiraishi
2009-02-24 9:59 ` [PATCH 2/3] Give short-hands to --pretty=tformat:%formatstring Nanako Shiraishi
2009-02-24 9:59 ` [PATCH 3/3] Add --oneline that is a synonym to "--pretty=oneline --abbrev-commit" Nanako Shiraishi
2009-02-24 17:38 ` Junio C Hamano
2009-02-24 21:06 ` [PATCH] Add tests for git log --pretty, --format and --oneline Felipe Contreras
2009-02-25 9:54 ` Junio C Hamano
2009-02-25 9:57 ` Jeff King
2009-02-25 10:16 ` Junio C Hamano
2009-02-25 10:20 ` Jeff King
2009-02-24 11:02 ` Teemu Likonen [this message]
2009-02-24 13:33 ` [PATCH v2] bash completion: add --format= and --oneline options for "git log" Teemu Likonen
2009-02-24 15:39 ` Shawn O. Pearce
2009-02-24 15:47 ` Teemu Likonen
2009-02-24 15:57 ` Shawn O. Pearce
2009-02-24 16:14 ` Teemu Likonen
2009-02-27 18:53 ` Teemu Likonen
2009-02-24 8:35 ` [RFC/PATCH] revision.c: add --format option for 'git log' Felipe Contreras
2009-02-22 20:34 ` Linus Torvalds
2009-02-22 22:12 ` Jakub Narebski
2009-02-23 9:55 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vtonlmv.fsf_-_@iki.fi \
--to=tlikonen@iki$(echo .)fi \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=nanako3@lavabit$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox