Subject: Re: [PATCH 6/7] git-blame.el: Doc fixes and cleanup

From: David Kågedal <[email-masked]>
Date: Fri, 09 Feb 2007 12:02:59 +0100

Jakub Narebski <[email-masked]> writes:

> [Cc: [email-masked]]
>
> David K?gedal wrote:
>
>> @@ -123,6 +123,7 @@
>>  
>>  ;;;###autoload
>>  (defun git-blame-mode (&optional arg)
>> +  "Minor mode for displaying Git blame"
>>    (interactive "P")
>>    (if arg
>>        (setq git-blame-mode (eq arg 1))
>
> We should probably also change file description in header, and autoload
> instruction in Installation: section of commentary:

Agreed.

> ;;; git-blame.el --- Minor mode for displaying Git blame  -*- coding: utf-8 -*-
> ;;
>
> [...]
>
> ;; If you do not want to load this package before it is necessary, you
> ;; can make use of the `autoload' feature, e.g. by adding to your .emacs
> ;; the following lines
> ;;
> ;;    (autoload 'git-blame-mode "git-blame"
> ;;              "Minor mode for displaying Git blame" t)
>
> (docstring is needed because INTERACTIVE is _fourth_ parameter).

Yes?  Of course you need the doc string here, since the file isn't
loaded yet.

-- 
David Kågedal