From: David Kastrup <dak@gnu•org>
To: michael@platin•gs
Cc: git@vger•kernel.org, "Jeff King" <peff@peff•net>,
"Stefan Beller" <stefanbeller@gmail•com>,
"Jeff Smith" <whydoubt@gmail•com>,
"Junio C Hamano" <gitster@pobox•com>,
"René Scharfe" <l.s.r@web•de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx•de>,
"Barret Rhoden" <brho@google•com>
Subject: Re: [PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines
Date: Sun, 07 Apr 2019 23:52:04 +0200 [thread overview]
Message-ID: <8736mtqy9n.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20190407214635.12984-1-michael@platin.gs> (michael@platin.gs's message of "Sun, 7 Apr 2019 23:46:35 +0200")
michael@platin•gs writes:
> From: Michael Platings <michael@platin•gs>
>
> Hi Barret,
> This is the updated fuzzy matching algorithm, sorry for the delay. It does
> highlight a bug in the calculation for the number of lines ("int nr_parent_lines
> = e->num_lines - delta;") - if you apply the patch, build it, then try to
> ./git blame --ignore-rev <the patch commit ID> blame.c then you'll get a segfault
> because nr_parent_lines is a negative number. I haven't had time to investigate further
> but I have confirmed that the bug is not due to my patch.
If you segfault with the patch and don't segfault with the patch, there
is not much of a point in declaring this "somebody else's problem", is
there? It has to be fixed anyway in order to make the patch get in.
Or am I fundamentally misunderstanding something here?
--
David Kastrup
next prev parent reply other threads:[~2019-04-07 21:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines>
2019-04-07 21:46 ` [PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines michael
2019-04-07 21:52 ` David Kastrup [this message]
2019-04-08 9:48 ` Michael Platings
2019-04-08 16:03 ` Barret Rhoden
2019-04-09 15:38 ` Junio C Hamano
2019-04-09 15:56 ` Barret Rhoden
2019-04-09 19:10 ` Barret Rhoden
2019-04-03 16:02 [PATCH v5 0/6] blame: add the ability to ignore commits Barret Rhoden
2019-04-03 16:02 ` [PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines Barret Rhoden
2019-04-04 16:37 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736mtqy9n.fsf@fencepost.gnu.org \
--to=dak@gnu$(echo .)org \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=avarab@gmail$(echo .)com \
--cc=brho@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=l.s.r@web$(echo .)de \
--cc=michael@platin$(echo .)gs \
--cc=peff@peff$(echo .)net \
--cc=stefanbeller@gmail$(echo .)com \
--cc=whydoubt@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox