public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Pat Thoyts <patthoyts@users•sourceforge.net>
To: Bert Wesarg <bert.wesarg@googlemail•com>
Cc: David Fries <David@Fries•net>, git@vger•kernel.org
Subject: Re: [RFC/PATCH 4/4] git-gui: incremental goto line in blame view
Date: Sat, 15 Oct 2011 23:26:46 +0100	[thread overview]
Message-ID: <8739etki1l.fsf@fox.patthoyts.tk> (raw)
In-Reply-To: <7a9760b8cf85274b17c7233f61f59bb59cd18578.1318513492.git.bert.wesarg@googlemail.com> (Bert Wesarg's message of "Thu, 13 Oct 2011 15:48:15 +0200")

Bert Wesarg <bert.wesarg@googlemail•com> writes:

>The view jumps now to the given line number after each key press.
>
>Signed-off-by: Bert Wesarg <bert.wesarg@googlemail•com>
>---
>
>I didn't know this before, but gedits goto-line-dialog works this way.
>
> lib/line.tcl |   15 +++++++++++----
> 1 files changed, 11 insertions(+), 4 deletions(-)
>
>diff --git a/lib/line.tcl b/lib/line.tcl
>index 70785e1..0113e06 100644
>--- a/lib/line.tcl
>+++ b/lib/line.tcl
>@@ -20,7 +20,7 @@ constructor new {i_w i_text args} {
> 		-background lightgreen \
> 		-validate key \
> 		-validatecommand [cb _validate %P]
>-	${NS}::button $w.bn      -text [mc Go] -command [cb _incrgoto]
>+	${NS}::button $w.bn      -text [mc Go] -command [cb _goto]
> 
> 	pack   $w.l   -side left
> 	pack   $w.bn  -side right
>@@ -29,7 +29,8 @@ constructor new {i_w i_text args} {
> 	eval grid conf $w -sticky we $args
> 	grid remove $w
> 
>-	bind $w.ent <Return> [cb _incrgoto]
>+	trace add variable linenum write [cb _goto_cb]
>+	bind $w.ent <Return> [cb _goto]
> 	bind $w.ent <Escape> [cb hide]
> 
> 	bind $w <Destroy> [list delete_this $this]
>@@ -67,10 +68,16 @@ method _validate {P} {
> 	return 0
> }
> 
>-method _incrgoto {} {
>+method _goto_cb {name ix op} {
>+	after idle [cb _goto 1]
>+}
>+
>+method _goto {{nohide {0}}} {
> 	if {$linenum ne {}} {
> 		$ctext see $linenum.0
>-		hide $this
>+		if {!$nohide} {
>+			hide $this
>+		}
> 	}
> }

Works fine. Will apply.

OK These 4 patches are applied and pushed to master branch - with
modifications made to 'only accept numbers in the goto-line input' made
as mentioned.

Thanks,

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD

next prev parent reply	other threads:[~2011-10-15 22:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 13:48 [PATCH 1/4] git-gui: search and linenumber input are mutual exclusive in the blame view Bert Wesarg
2011-10-13 13:48 ` [PATCH 2/4] git-gui: clear the goto line input when hiding Bert Wesarg
2011-10-15 22:20   ` Pat Thoyts
2011-10-16 10:29     ` Bert Wesarg
2011-10-13 13:48 ` [PATCH 3/4] git-gui: only except numbers in the goto-line input Bert Wesarg
2011-10-15 22:17   ` Pat Thoyts
2011-10-16 10:32     ` Bert Wesarg
2011-10-13 13:48 ` [RFC/PATCH 4/4] git-gui: incremental goto line in blame view Bert Wesarg
2011-10-15 22:26   ` Pat Thoyts [this message]
2011-10-15 22:22 ` [PATCH 1/4] git-gui: search and linenumber input are mutual exclusive in the " Pat Thoyts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739etki1l.fsf@fox.patthoyts.tk \
    --to=patthoyts@users$(echo .)sourceforge.net \
    --cc=David@Fries$(echo .)net \
    --cc=bert.wesarg@googlemail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox