public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: David Kastrup <dak@gnu•org>
To: Shawn Pearce <spearce@spearce•org>
Cc: git <git@vger•kernel.org>
Subject: Re: [PATCH 1/2] blame: large-scale performance rewrite
Date: Sat, 26 Apr 2014 19:30:06 +0200	[thread overview]
Message-ID: <874n1g80dd.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87d2g481nb.fsf@fencepost.gnu.org> (David Kastrup's message of "Sat, 26 Apr 2014 19:02:32 +0200")

David Kastrup <dak@gnu•org> writes:

> http://repo.or.cz/r/wortliste.git
> git blame [-M / -C] wortliste
>
> The latter one is _really_ taking a severe hit from the O(n^2)
> algorithms.  If your benchmarks for that one still point mostly to the
> unpacking, your jgit blame should be fine regarding the stuff
> I reimplemented.

Here's some example:

dak@lola:/usr/local/tmp/wortliste$ time git blame -n -s wortliste >/tmp/wl1

real	15m47.118s
user	14m39.928s
sys	1m1.872s
dak@lola:/usr/local/tmp/wortliste$ time ../git/git blame -n -s wortliste >/tmp/wl2

real	3m40.947s
user	2m40.296s
sys	0m59.440s

Note how the system time is almost the same.  I have some patches which
make quite a bit of difference with that (at best, saving about half of
the system time), but I have not yet found the silver bullet where I'd
be reasonably sure that temporary memory use with non-linear history
stays strictly in nice bounds.

-- 
David Kastrup

  reply	other threads:[~2014-04-26 17:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 23:56 [PATCH 1/2] blame: large-scale performance rewrite David Kastrup
2014-04-25 23:56 ` [PATCH 2/2] Mention "git blame" improvements in release notes David Kastrup
2014-04-26 17:28   ` Junio C Hamano
2014-04-26 18:28     ` David Kastrup
     [not found]       ` <xmqqzjj5s8hs.fsf@gitster.dls.corp.google.com>
2014-04-28 17:39         ` David Kastrup
2014-04-28 19:35           ` Junio C Hamano
2014-04-28 19:57             ` David Kastrup
2014-04-28 20:05             ` Ronnie Sahlberg
2014-04-28 20:26               ` David Kastrup
2014-04-26  0:53 ` [PATCH 1/2] blame: large-scale performance rewrite Shawn Pearce
2014-04-26  7:48   ` David Kastrup
2014-04-26 16:01     ` Shawn Pearce
2014-04-26 16:50       ` David Kastrup
2014-04-26 17:09         ` Shawn Pearce
2014-04-26 17:22           ` David Kastrup
2014-04-26 17:02       ` David Kastrup
2014-04-26 17:30         ` David Kastrup [this message]
2014-04-26 17:56           ` Shawn Pearce
2014-04-26 21:39             ` David Kastrup
2014-04-27 17:53               ` Shawn Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874n1g80dd.fsf@fencepost.gnu.org \
    --to=dak@gnu$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=spearce@spearce$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox