From: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org,
Linus Torvalds <torvalds@linux-foundation•org>,
Edward Thomson <ethomson@edwardthomson•com>,
"brian m . carlson" <sandals@crustytoothpaste•net>,
Jonathan Nieder <jrnieder@gmail•com>,
Johannes Schindelin <Johannes.Schindelin@gmx•de>,
demerphq <demerphq@gmail•com>,
Brandon Williams <bmwill@google•com>,
Derrick Stolee <stolee@gmail•com>
Subject: Re: Questions about the hash function transition
Date: Thu, 23 Aug 2018 17:20:04 +0200 [thread overview]
Message-ID: <876001f6u3.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqy3cxjgz1.fsf@gitster-ct.c.googlers.com>
On Thu, Aug 23 2018, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
>
>>> - The trailer consists of the following:
>>> - A copy of the 20-byte SHA-256 checksum at the end of the
>>> corresponding packfile.
>>>
>>> - 20-byte SHA-256 checksum of all of the above.
>>
>> We need to update both of these to 32 byte, right? Or are we planning to
>> truncate the checksums?
>
> https://public-inbox.org/git/CA+55aFwc7UQ61EbNJ36pFU_aBCXGya4JuT-TvpPJ21hKhRengQ@mail.gmail.com/
Thanks.
Yeah for this checksum purpose even 10 or 5 characters would do, but
since we'll need a new pack format anyway for SHA-256 why not just use
the full length of the SHA-256 here? We're using the full length of the
SHA-1.
I don't see it mattering for security / corruption detection purposes,
but just to avoid confusion. We'll have this one place left where
something looks like a SHA-1, but is actually a trunctated SHA-256.
next prev parent reply other threads:[~2018-08-23 15:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 14:02 Questions about the hash function transition Ævar Arnfjörð Bjarmason
2018-08-23 14:27 ` Junio C Hamano
2018-08-23 15:20 ` Ævar Arnfjörð Bjarmason [this message]
2018-08-23 16:13 ` Junio C Hamano
2018-08-24 1:40 ` brian m. carlson
2018-08-24 1:54 ` Jonathan Nieder
2018-08-24 4:47 ` brian m. carlson
2018-08-24 4:52 ` Jonathan Nieder
2018-08-24 1:47 ` Jonathan Nieder
2018-08-28 12:04 ` Johannes Schindelin
2018-08-28 12:49 ` Derrick Stolee
2018-08-28 17:12 ` Jonathan Nieder
2018-08-28 17:11 ` Jonathan Nieder
2018-08-29 13:09 ` Johannes Schindelin
2018-08-29 13:27 ` Derrick Stolee
2018-08-29 14:43 ` Derrick Stolee
2018-08-29 9:13 ` How is the ^{sha256} peel syntax supposed to work? Ævar Arnfjörð Bjarmason
2018-08-29 17:51 ` Stefan Beller
2018-08-29 17:59 ` Jonathan Nieder
2018-08-29 18:34 ` Stefan Beller
2018-08-29 18:41 ` Ævar Arnfjörð Bjarmason
2018-08-29 19:12 ` Jonathan Nieder
2018-08-29 19:37 ` Ævar Arnfjörð Bjarmason
2018-08-29 20:46 ` Jonathan Nieder
2018-08-29 23:45 ` Jeff King
2018-08-29 20:53 ` Junio C Hamano
2018-08-29 21:01 ` Jonathan Nieder
2018-08-29 17:56 ` Jonathan Nieder
2018-08-24 2:51 ` Questions about the hash function transition Jonathan Nieder
2018-08-28 13:50 ` Ævar Arnfjörð Bjarmason
2018-08-28 14:15 ` Edward Thomson
2018-08-28 15:02 ` Ævar Arnfjörð Bjarmason
2018-08-28 15:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876001f6u3.fsf@evledraar.gmail.com \
--to=avarab@gmail$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=bmwill@google$(echo .)com \
--cc=demerphq@gmail$(echo .)com \
--cc=ethomson@edwardthomson$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=stolee@gmail$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox