Subject: Re: [PATCH] bisect: allow to run from subdirectories

From: Ævar Arnfjörð Bjarmason <[email-masked]>
Date: Mon, 21 Jun 2021 02:35:49 +0200

On Sun, Jun 20 2021, Roland Hieber wrote:

> Currently, calling 'git bisect' from a directory other than the top
> level of a repository only comes up with an error message:
>
>     You need to run this command from the toplevel of the working tree.
>
> After a glance through the bisect code, there seems to be nothing that
> relies on the current working directory, and a few hours of bisect usage
> also didn't turn up any problems. Set the appropriate flag for
> git-sh-setup to remove the error message.
>
> Signed-off-by: Roland Hieber <[email-masked]>
> ---
>  git-bisect.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/git-bisect.sh b/git-bisect.sh
> index 6a7afaea8da0..20ba0ee7c18a 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -32,6 +32,7 @@ git bisect run <cmd>...
>  Please use "git help bisect" to get the full man page.'
>  
>  OPTIONS_SPEC=
> +SUBDIRECTORY_OK=1
>  . git-sh-setup
>  
>  _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'

How does this affect out-of-tree scripts that will be run with "git
bisect run", is the cwd set to the root as they now might expect git to
check, or whatever subdirectory you ran the "run" from?