From: Thomas Rast <tr@thomasrast•ch>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)
Date: Sat, 26 Oct 2013 10:35:17 +0200 [thread overview]
Message-ID: <877gd0pgze.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <20131024084638.GA761@sigill.intra.peff.net> (Jeff King's message of "Thu, 24 Oct 2013 04:46:38 -0400")
Jeff King <peff@peff•net> writes:
> diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
> index 752f5cb..2b4b9a9 100755
[...]
> +test_atom head *objectname ''
> +test_atom head *objecttype ''
[...]
> +test_atom tag *objectname '67a36f10722846e891fbada1ba48ed035de75581'
> +test_atom tag *objecttype 'commit'
Can you quote the *? I may have become somewhat paranoid, but still.
This is the first use of the *<field> syntax, and test_atom seems
written to correctly quote its arguments, so why risk it? :-)
--
Thomas Rast
tr@thomasrast•ch
next prev parent reply other threads:[~2013-10-26 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 8:46 [PATCH] for-each-ref: avoid loading objects to print %(objectname) Jeff King
2013-10-26 8:35 ` Thomas Rast [this message]
2013-10-30 6:50 ` Jeff King
2013-10-30 17:34 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2013-10-04 7:56 Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gd0pgze.fsf@linux-k42r.v.cablecom.net \
--to=tr@thomasrast$(echo .)ch \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox