From: Eric Lesh <eclesh@ucla•edu>
To: "Thomas Adam" <thomas.adam22@gmail•com>
Cc: "David Kastrup" <dak@gnu•org>, git@vger•kernel.org
Subject: Re: [GUILT PATCH 2/5] guilt-guard: Assign guards to patches in series
Date: Thu, 09 Aug 2007 01:53:28 -0700 [thread overview]
Message-ID: <877io5nl6f.fsf@hubert.paunchy.net> (raw)
In-Reply-To: <18071eea0708090122h79dec205j4528f4dfd7aab588@mail.gmail.com> (Thomas Adam's message of "Thu\, 9 Aug 2007 09\:22\:44 +0100")
"Thomas Adam" <thomas.adam22@gmail•com> writes:
> On 09/08/07, David Kastrup <dak@gnu•org> wrote:
>> sed -i -e "s,^\($p[[:space:]]*.*\)\$,\1 #$x," "$series"
>>
>> and that's fine.
>
> I'm surprised to see 'sed -i' being at all, it's certainly non-portable.
>
> -- Thomas Adam
You're definitely right. I've been asked to change this a couple of
times and keep forgetting. Thanks for the reminder.
Eric
next prev parent reply other threads:[~2007-08-09 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 3:11 [GUILT PATCH v2 0/5] Add guards to guilt Eric Lesh
2007-07-31 3:11 ` [GUILT PATCH 1/5] get_series: Remove comments from end of series lines Eric Lesh
2007-07-31 3:50 ` Josef Sipek
2007-07-31 3:11 ` [GUILT PATCH 2/5] guilt-guard: Assign guards to patches in series Eric Lesh
2007-07-31 4:05 ` Josef Sipek
2007-08-09 7:34 ` Eric Lesh
2007-08-09 8:17 ` David Kastrup
2007-08-09 8:22 ` Thomas Adam
2007-08-09 8:43 ` David Kastrup
2007-08-09 8:53 ` Eric Lesh [this message]
2007-08-09 9:01 ` Eric Lesh
2007-08-09 13:47 ` Josef Sipek
2007-07-31 3:11 ` [GUILT PATCH 3/5] guilt-select: Select guards to apply when pushing patches Eric Lesh
2007-07-31 3:11 ` [GUILT PATCH 4/5] get_series: return guarded patches only Eric Lesh
2007-07-31 3:11 ` [GUILT PATCH 5/5] Guards test suite Eric Lesh
2007-07-31 3:42 ` [GUILT PATCH v2 0/5] Add guards to guilt Josef Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877io5nl6f.fsf@hubert.paunchy.net \
--to=eclesh@ucla$(echo .)edu \
--cc=dak@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=thomas.adam22@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox