From: Toon Claes <toon@iotcl•com>
To: Karthik Nayak <karthik.188@gmail•com>, git@vger•kernel.org
Cc: chriscool@tuxfamily•org, jltobler@gmail•com, gitster@pobox•com,
Karthik Nayak <karthik.188@gmail•com>
Subject: Re: [PATCH v2 0/3] clang-format: modify rules to reduce false-positives
Date: Tue, 01 Jul 2025 15:36:18 +0200 [thread overview]
Message-ID: <878ql8qbhp.fsf@iotcl.com> (raw)
In-Reply-To: <20250630-525-make-clang-format-more-robust-v2-0-05cbcdbf7817@gmail.com>
Karthik Nayak <karthik.188@gmail•com> writes:
> This series is in response to an email thread [1] around the usage of
> '.clang-format' and its effectiveness.
>
> The goal of the series is to improve the usage of 'clang-format' in the
> repository. To do this we:
> 1. Reduce the number of false positives. Majority of which is due to
> line-wrapping. We remove the 'ColumnLimit' from 'clang-format'. This
> removes the responsibility of line-wrapping from 'clang-format' and puts
> it into the hands of the user.
> 2. Add a rule to 'meson' to run 'git clang-format' by running 'meson
> compile style'.
> 3. Make the 'RemoveBracesLLVM' permanent by moving it to
> '.clang-format'.
Thanks for working on this. While the changes are not huge, I appreciate
them.
> With this, running `git clang-format` for the last 25 commits in master,
> seems to produce much less false positives.
>
> [snip]
>
> diff --git a/pathspec.h b/pathspec.h
> index 5e3a6f1fe7..601b9ca201 100644
> --- a/pathspec.h
> +++ b/pathspec.h
> @@ -80,7 +80,7 @@ struct pathspec {
> * For git diff --no-index, indicate that we are operating without
> * a repository or index.
> */
> -#define PATHSPEC_NO_REPOSITORY (1<<7)
> +#define PATHSPEC_NO_REPOSITORY (1 << 7)
I'm surprised, but I couldn't find a setting to change this...
--
Cheers,
Toon
next prev parent reply other threads:[~2025-07-01 13:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 16:43 [PATCH 0/4] clang-format: modify rules to reduce false-positives Karthik Nayak
2025-06-25 16:43 ` [PATCH 1/4] editorconfig: set maximum line length to 120 characters Karthik Nayak
2025-06-25 18:41 ` Junio C Hamano
2025-06-26 8:27 ` Karthik Nayak
2025-06-26 14:25 ` Junio C Hamano
2025-06-27 8:38 ` Karthik Nayak
2025-06-26 16:22 ` Justin Tobler
2025-06-27 8:51 ` Karthik Nayak
2025-06-27 15:12 ` Justin Tobler
2025-06-30 8:29 ` Karthik Nayak
2025-06-25 16:43 ` [PATCH 2/4] clang-format: set 'ColumnLimit' to 0 Karthik Nayak
2025-06-25 16:43 ` [PATCH 3/4] clang-format: add 'RemoveBracesLLVM' to the main config Karthik Nayak
2025-06-25 16:43 ` [PATCH 4/4] meson: add rule to run 'git clang-format' Karthik Nayak
2025-06-26 16:35 ` Justin Tobler
2025-06-27 8:12 ` Karthik Nayak
2025-06-27 14:25 ` Junio C Hamano
2025-06-30 8:34 ` Karthik Nayak
2025-06-30 15:24 ` Junio C Hamano
2025-06-30 8:38 ` [PATCH v2 0/3] clang-format: modify rules to reduce false-positives Karthik Nayak
2025-06-30 8:38 ` [PATCH v2 1/3] clang-format: set 'ColumnLimit' to 0 Karthik Nayak
2025-06-30 8:38 ` [PATCH v2 2/3] clang-format: add 'RemoveBracesLLVM' to the main config Karthik Nayak
2025-06-30 8:38 ` [PATCH v2 3/3] meson: add rule to run 'git clang-format' Karthik Nayak
2025-07-01 10:13 ` Patrick Steinhardt
2025-07-01 15:08 ` Karthik Nayak
2025-07-01 16:02 ` Junio C Hamano
2025-07-01 13:26 ` Toon Claes
2025-07-01 15:12 ` Karthik Nayak
2025-07-02 2:54 ` Patrick Steinhardt
2025-06-30 15:27 ` [PATCH v2 0/3] clang-format: modify rules to reduce false-positives Junio C Hamano
2025-07-01 13:36 ` Toon Claes [this message]
2025-07-01 15:19 ` Karthik Nayak
2025-07-01 20:49 ` Junio C Hamano
2025-07-02 9:23 ` [PATCH v3 " Karthik Nayak
2025-07-02 9:23 ` [PATCH v3 1/3] clang-format: set 'ColumnLimit' to 0 Karthik Nayak
2025-07-02 9:23 ` [PATCH v3 2/3] clang-format: add 'RemoveBracesLLVM' to the main config Karthik Nayak
2025-07-02 9:23 ` [PATCH v3 3/3] meson: add rule to run 'git clang-format' Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ql8qbhp.fsf@iotcl.com \
--to=toon@iotcl$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jltobler@gmail$(echo .)com \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox