Subject: Re: [PATCH] mailmap: fix check for freeing memory

From: Thomas Rast <[email-masked]>
Date: Tue, 20 Aug 2013 15:40:02 +0200

Stefan Beller <[email-masked]> writes:

> The condition as it is written in that line was most likely intended to
> check for the pointer passed to free(), rather than checking for the
> 'repo_abbrev', which is already checked against being non null at the
> beginning of the function.
[...]
> -			if (repo_abbrev)
> +			if (*repo_abbrev)
>  				free(*repo_abbrev);

But now the test is useless, because free(NULL) is defined to be a
no-op.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch